Make sourcemap generation a bit faster, roll #2 #2903
Conversation
| if (this._contentsIgnoredCharsMap[filename]) { | ||
| source = source.slice(this._contentsIgnoredCharsMap[filename]); | ||
| } | ||
| for (var filename in this._contentsInfoMap) { |
There was a problem hiding this comment.
the bug in the last PR was that this line was still referencing this._contentsMap
|
It appears the Travis build fails because the inline source maps don't match? |
|
ya, it works for me locally...i don't know enough about your CI setup to know why it would be different there. |
|
@nicks Can you take another whack at running tests locally? There's no reason they should pass on another system. Are you running |
nicks
force-pushed
the
nicks/sourcemap
branch
5 times, most recently
from
c1c4ca5
to
e19b995
Compare
|
Ya. I think the problem is that the source-map library generates different source-maps on OSX vs Linux, and this PR is the first thing in this repo that adds tests for source-maps. I added a replacer so that it's not checking the exact source-map contents, just that it exists. |
|
(the travis test failures are spurious, appears to be a problem with your test setup) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Makes sourcemap generation a bit faster. Re-try of #2834
Also adds tests for different source map generation options.