Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local middleware options #68

Closed
wants to merge 2 commits into from
Closed

Local middleware options #68

wants to merge 2 commits into from

Conversation

vectart
Copy link
Contributor

@vectart vectart commented Feb 1, 2017

This PR adds an ability to set middleware-specific options that will simply override global ones.
Thus, it'll be possible to set route-specific appendKey, defaultDuration and others.

@davebaol
Copy link
Contributor

davebaol commented Jun 28, 2017

I've not looked into the proposed implementation, but generally speaking this is definitely a must-have feature for advanced usage scenarios.
Please, review this PR 😃

@kwhitley
Copy link
Owner

Alright guys - my apologies for the long wait on this one, but it'll go to the top of my list!

Thanks @vectart for the perfect PR (implementation + README + tests) 👍 👍 👍

@kwhitley
Copy link
Owner

kwhitley commented Aug 9, 2017

I'll be merging this in as soon as #97 clears - still waiting on node-restify to merge a @svozza fix and publish for all to clear.

@kwhitley
Copy link
Owner

kwhitley commented Aug 9, 2017

@vectart This has been merged into #97 and will be rolled out shortly in v0.9.0! Thanks again!

@kwhitley kwhitley closed this Aug 9, 2017
kwhitley pushed a commit that referenced this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants