Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.18] Fix VirtualMachineCRCErrors not stop firing #907

Merged
merged 4 commits into from Mar 5, 2024
Merged

[release-v0.18] Fix VirtualMachineCRCErrors not stop firing #907

merged 4 commits into from Mar 5, 2024

Commits on Mar 4, 2024

  1. Fix VirtualMachineCRCErrors not getting resolved 

    The controller keeps reporting old metric values
even after the VM is deleted. This commit updates
the metric name and labels so that we can set up
the metric value to 0, and no longer trigger the
alert on VM deletion

Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Mar 4, 2024
    Copy the full SHA
    b6da5aa View commit details
    Browse the repository at this point in the history

  2. Add offset to ginkgo e2e validations 

    Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Mar 4, 2024
    Copy the full SHA
    bbf2af1 View commit details
    Browse the repository at this point in the history

  3. Update tests/monitoring_test.go 

    Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Mar 4, 2024
    Copy the full SHA
    25e1aa9 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix MatchError error 

    Signed-off-by: João Vilaça <jvilaca@redhat.com>
    @machadovilaca
    machadovilaca committed Mar 5, 2024
    Copy the full SHA
    04af2c8 View commit details
    Browse the repository at this point in the history