[release-v0.18] Fix VirtualMachineCRCErrors not stop firing #907
Conversation
The controller keeps reporting old metric values even after the VM is deleted. This commit updates the metric name and labels so that we can set up the metric value to 0, and no longer trigger the alert on VM deletion Signed-off-by: João Vilaça <jvilaca@redhat.com>
Signed-off-by: João Vilaça <jvilaca@redhat.com>
kubevirt-bot
added
release-note
Signed-off-by: João Vilaça <jvilaca@redhat.com>
|
@machadovilaca Looks like the e2e test you introduced with this PR is failing? |
Signed-off-by: João Vilaça <jvilaca@redhat.com>
|
| @@ -287,7 +286,7 @@ var _ = Describe("Prometheus Alerts", func() { | |||
|
|
|||
| Eventually(func(g Gomega) error { | |||
| return apiClient.Get(ctx, types.NamespacedName{Name: vmName, Namespace: strategy.GetNamespace()}, vm) | |||
| }).Should(MatchError(k8serrors.IsNotFound)) | |||
There was a problem hiding this comment.
IIRC this syntax is just missing a string as second argument
e.g.
Should(MatchError(k8serrors.IsNotFound, "IsNotFound"))
There was a problem hiding this comment.
that is what we have in main branch, but that caused the automatic cherry-pick to fail. Probably here we have an older version of gomega
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
This is a manual cherry-pick of #742
https://issues.redhat.com/browse/CNV-35848
Release note: