Update operator-observability version #1774
Conversation
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
kubevirt-bot
added
release-note-none
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
|
|
Thanks If there is any specific reason maybe worth to add to PR desc /lgtm |
sorry, the description was inside the comment delimiters, updated |
|
Thanks |
| @@ -14,7 +14,7 @@ require ( | |||
| github.com/gobwas/glob v0.2.3 | |||
| github.com/google/go-github/v32 v32.1.0 | |||
| github.com/kubevirt/monitoring/pkg/metrics/parser v0.0.0-20231024120544-6a3ba1a680b4 | |||
| github.com/machadovilaca/operator-observability v0.0.7 | |||
| github.com/machadovilaca/operator-observability v0.0.19-0.20240326121036-9f2e5a31675f | |||
There was a problem hiding this comment.
@RamLavi
Are we fine with custom version ? (here and on few others)
I believe we do since it is official repo, but will be good to have your opinion please
fwiw we are doing the same already one line above
once we want to upgrade again, we will need to change the updated packages together possibly
There was a problem hiding this comment.
I don't think we have a problem with that, but one has to make sure to not take a "half baked" version, so it makes sense for @machadovilaca to explain on the commit message why he intentionally didn't choose a formal release for operator-observability (is it because there isn't one yet that has the fix you need? If so - can you try and reach out their maintainer and ask them to issue one?)
There was a problem hiding this comment.
IIUC it is because real breaking changes that aint easy to fix
kubernetes/client-go#1075 (comment)
CNAO depends on kubevirt client which use old libs, and if we want to update here, it will conflict
but sure lets hear the PR author he knows best of course
There was a problem hiding this comment.
due to versions incompatibilities between dependency packages, namely prometheus-operator -> controller-runtime, the proposed version for the operator-observability package, which is not a streamlined version therefore the custom version, uses Golang 1.19 and a downgraded version of prometheus-operator which is compatible with CNAO current state
|
/test pull-e2e-cluster-network-addons-operator-lifecycle-k8s |
|
Thanks /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
operator-observabilityuses Go 1.21 with a matching version forprometheus-operator/prometheus-operatorthat was causingincompatibilities with CNAO
controller-runtimeversion. This PRupdates
operator-observabilityto a custom working version/cc @assafad
What this PR does / why we need it:
Special notes for your reviewer:
Release note: