Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test TestZeroRequest #66471

Merged
merged 1 commit into from Jul 24, 2018
Merged

Improve unit test TestZeroRequest #66471

merged 1 commit into from Jul 24, 2018

Conversation

islinwb
Copy link
Contributor

@islinwb islinwb commented Jul 21, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #66468

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2018
@islinwb
Copy link
Contributor Author

islinwb commented Jul 21, 2018

/assign @bsalamat

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2018
@islinwb
Copy link
Contributor Author

islinwb commented Jul 22, 2018

/test pull-kubernetes-e2e-kops-aws

@yastij
Copy link
Member

yastij commented Jul 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2018
@yastij
Copy link
Member

yastij commented Jul 22, 2018

/cc @bsalamat

can you review and approve ? Thanks

bsalamat
bsalamat reviewed Jul 22, 2018
View reviewed changes
pkg/scheduler/core/generic_scheduler_test.go Outdated
@@ -684,12 +687,12 @@ func TestZeroRequest(t *testing.T) {
}
for _, hp := range list {
if test.name == "test priority of larger pod with machine with zero-request pod" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually want to get rid of this if statement here. We should not rely on the name of the test. Please remove this if statement and provide the expected score in the corresponding test case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsalamat Sorry, I thougt the score of the third case varies.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
bsalamat
bsalamat approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, islinwb, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 66291, 66471, 66499). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 4dbcf32 into kubernetes:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@davidopp davidopp Awaiting requested review from davidopp

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@yastij yastij

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve unit tests of generic_scheduler
5 participants
@islinwb @yastij @k8s-ci-robot @k8s-github-robot @bsalamat