New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual cherry pick of #124559 upstream release 1.27 #124765
Manual cherry pick of #124559 upstream release 1.27 #124765
Conversation
…egal nodes, the pod scheduling flow will abort immediately. this is a minimum fix from kubernetes#119779 Signed-off-by: joey <zchengjoey@gmail.com>
Hi @chengjoey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind regression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
/cc kubernetes/release-managers
LGTM label has been added. Git tree hash: f6ddc375f96faf0df4472d87555b73319f1f12eb
|
…nt/existent nodes Signed-off-by: joey <zchengjoey@gmail.com> (cherry picked from commit a56cc6b)
85961a3
to
12a3594
Compare
12a3594
to
8b595e5
Compare
8b595e5
to
cd50a0a
Compare
/test pull-kubernetes-unit |
@alculquicondor please lgtm again, same with #124764 |
/lgtm |
LGTM label has been added. Git tree hash: bb568cfa00a226cd3b1888bc7d0555d13cce69a8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, chengjoey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process. If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document. AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Manual cherry pick of #124559 on release-1.27.
#124559 : hotfix when a plugin (in-tree or out-of-tree) return non-existent/illegal nodes, the pod scheduling flow will abort immediately
Does this PR introduce a user-facing change?