Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a deprecating featurer gate to fix cost #124675

Merged
merged 1 commit into from May 13, 2024
Merged

Adding a deprecating featurer gate to fix cost #124675

merged 1 commit into from May 13, 2024

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented May 2, 2024 •
edited

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #124542

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added the feature gates `StrictCostEnforcementForVAP` and `StrictCostEnforcementForWebhooks` to enforce the strct cost calculation for CEL extended libraries. It is strongly recommended to turn on the feature gates as early as possible.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2024
@cici37 cici37 mentioned this pull request May 2, 2024
Open
@cici37
Copy link
Contributor Author

cici37 commented May 2, 2024

/assign @liggitt @jpbetz
The cherry pick into 1.30: #124676
I'll turn on the feature gate in 1.31 in a followup PR.
Please feel free to let me know if anything else is needed. Thank you!
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@cici37 cici37 force-pushed the fgForCost branch 2 times, most recently from 60f2911 to 81f1682 Compare May 6, 2024 14:43
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: adf0304313b114a88eec7b9c468f1b715d93f8f3

@liggitt
Copy link
Member

liggitt commented May 10, 2024

/hold in case you want to squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@cici37
Copy link
Contributor Author

cici37 commented May 10, 2024

Thank you! Squashed :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@liggitt
Copy link
Member

liggitt commented May 10, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@liggitt
Copy link
Member

liggitt commented May 10, 2024

/hold

I had one more question... if the gates default on, do unit/integration tests still pass or are there some that need to explicitly assert non-strict cost?

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 10, 2024
@cici37
Copy link
Contributor Author

cici37 commented May 10, 2024

Updates: All CI passed. I am dropping the temp commit and squash the changes.

@cici37
Copy link
Contributor Author

cici37 commented May 10, 2024

/retest

@cici37
Copy link
Contributor Author

cici37 commented May 11, 2024

@liggitt I believe the concern has been addressed and tested in CI. Would you mind taking a look when have time? Thank you!

@bart0sh bart0sh added this to not-sig-node in SIG Node PR Triage May 13, 2024
@liggitt
Copy link
Member

liggitt commented May 13, 2024

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 09a688fa6e0d56313aae5eaee5c6ef176aec0209

@k8s-ci-robot k8s-ci-robot merged commit 119f9b3 into kubernetes:master May 13, 2024
20 checks passed
SIG Node PR Triage automation moved this from not-sig-node to Done May 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 13, 2024
@cici37 cici37 deleted the fgForCost branch May 13, 2024 15:53
@cici37 cici37 mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@jpbetz jpbetz Awaiting requested review from jpbetz

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@jpbetz jpbetz

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: Closed / Done
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

ValidatingAdmissionPolicy: Cost estimator for extended library was not registered
5 participants
@cici37 @k8s-triage-robot @jpbetz @liggitt @k8s-ci-robot