api: add plural exception for "parameters"

[pohly]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This is for ResourceClassParameters and ResourceClaimParameters (added in 1.30). Without this, the fake clientset does not handle those objects correctly because it computes the resource name
incorrectly ("resourceclassparameterses").

Which issue(s) this PR fixes:

Nothing affected in the wild (yet).

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly
Once this PR has been reviewed and has the lgtm label, please assign caesarxuchao for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apimachinery/pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jiahuif]

/assign @liggitt
For staging/apimachinery
Thank you
/triage accepted

[liggitt]

xref previous attempts to expand this function in #110053

I'm -1 on adding more things to this list for the same reasons indicated in that issue. Changes here affects all apimachinery callers ... instead, this should be motivation to fix how fake clients are told the resource name to use (e.g. attempts in #119924)

[pohly]

Ack. Is there any short-term workaround? I need the fake client to handle ResourceClaimParameters and ResourceClassParameters correctly for unit testing in #123938.

[pohly]

I found a workaround:

	// Quick-and-dirty workaround for fake client storing ResourceClassParameters and
	// ResourceClaimParameters as "resourceclassparameterses" and "resourceclaimparameterses":
	// intercept the correct LIST from the informers and reply to them with the incorrect
	// LIST result.
	tc.client.PrependReactor("list", "resourceclaimparameters", createListReactor(tc.client.Tracker(), "ResourceClaimParameters"))
	tc.client.PrependReactor("list", "resourceclassparameters", createListReactor(tc.client.Tracker(), "ResourceClassParameters"))

...

func createListReactor(tracker cgotesting.ObjectTracker, kind string) func(action cgotesting.Action) (handled bool, ret apiruntime.Object, err error) {
	return func(action cgotesting.Action) (handled bool, ret apiruntime.Object, err error) {
		// listAction := action.(cgotesting.ListAction)
		gvr := action.GetResource()
		ns := action.GetNamespace()
		gvr.Resource += "es"
		list, err := tracker.List(gvr, schema.GroupVersionKind{Group: gvr.Group, Version: gvr.Version, Kind: kind}, ns)
		return true, list, err
	}
}

/close

[k8s-ci-robot]

@pohly: Closed this PR.

In response to this:

I found a workaround:

  // Quick-and-dirty workaround for fake client storing ResourceClassParameters and
  // ResourceClaimParameters as "resourceclassparameterses" and "resourceclaimparameterses":
  // intercept the correct LIST from the informers and reply to them with the incorrect
  // LIST result.
  tc.client.PrependReactor("list", "resourceclaimparameters", createListReactor(tc.client.Tracker(), "ResourceClaimParameters"))
  tc.client.PrependReactor("list", "resourceclassparameters", createListReactor(tc.client.Tracker(), "ResourceClassParameters"))

...

func createListReactor(tracker cgotesting.ObjectTracker, kind string) func(action cgotesting.Action) (handled bool, ret apiruntime.Object, err error) {
  return func(action cgotesting.Action) (handled bool, ret apiruntime.Object, err error) {
  	// listAction := action.(cgotesting.ListAction)
  	gvr := action.GetResource()
  	ns := action.GetNamespace()
  	gvr.Resource += "es"
  	list, err := tracker.List(gvr, schema.GroupVersionKind{Group: gvr.Group, Version: gvr.Version, Kind: kind}, ns)
  	return true, list, err
  }
}

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.