New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StructuredResourceModel to UnprepareResources call #123831
Add StructuredResourceModel to UnprepareResources call #123831
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest For approval. |
LGTM label has been added. Git tree hash: fea1fcf276b7358a7be6a74a2a8fc04ad7adadf9
|
Signed-off-by: Kevin Klues <kklues@nvidia.com>
24e8eef
to
13a6dcc
Compare
/test pull-kubernetes-verify |
/lgtm /cc @kubernetes/release-team Please add the 1.30 milestone, this is a fix for a feature that went into 1.30. |
@pohly: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-team. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: c2757a488696e0df64590217464ec305398f2795
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klueska, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saschagrunert: milestone still needed? |
/milestone v1.30 /cc @kubernetes/release-team |
@saschagrunert: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-team. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds the StructuredResourceModel field to the UnprepareResources call for a DRA kubelet plugin. It was always meant to be passed, and adding it in was overlooked and causing bugs in external plugin implementations.