Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job: Use the fake clock in TestTrackJobStatusAndRemoveFinalizers #123826

Merged
merged 1 commit into from Mar 8, 2024
Merged

Job: Use the fake clock in TestTrackJobStatusAndRemoveFinalizers #123826

merged 1 commit into from Mar 8, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Mar 8, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a follow-up PR of the #123412.
As I discussed in https://github.com/kubernetes/kubernetes/pull/123412/files#r1514820338 with @alculquicondor we should use the fake clock to avoid complexity in the TestTrackJobStatusAndRemoveFinalizers.

Which issue(s) this PR fixes:

Part-of: kubernetes/enhancements#3998

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 8, 2024
@tenzen-y tenzen-y mentioned this pull request Mar 8, 2024
Open
15 tasks
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2024
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 8, 2024

/assign @alculquicondor

alculquicondor
alculquicondor reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/controller/job/job_controller_test.go Outdated
@@ -1443,7 +1446,7 @@ func TestTrackJobStatusAndRemoveFinalizers(t *testing.T) {
Succeeded: 1,
Failed: 1,
Conditions: []batch.JobCondition{*succeededCond, *completedCond},
CompletionTime: &succeededCond.LastTransitionTime,
CompletionTime: ptr.To[metav1.Time](metav1.NewTime(now)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CompletionTime: ptr.To[metav1.Time](metav1.NewTime(now)),
CompletionTime: ptr.To(metav1.NewTime(now)),

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@tenzen-y
Job: Use the fake clock in TestTrackJobStatusAndRemoveFinalizers
f2508df 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 8, 2024

@alculquicondor I addressed your comment.

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3d9d090f186c11e5a0a782a2f1ef5277cb18c1da

@alculquicondor
Copy link
Member

/milestone v1.30

This qualifies for test freeze

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit d3d06c3 into kubernetes:master Mar 8, 2024
14 checks passed
@tenzen-y tenzen-y deleted the use-fake-client-job-unit branch March 8, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kow3ns kow3ns Awaiting requested review from kow3ns

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tenzen-y @k8s-ci-robot @alculquicondor