Update Job conformance test for job status updates #123751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/test
sig/apps
|
/cc @atiratree |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a862c0df671fb81c28278098531116d484436672
|
|
/triage accepted |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
triage/accepted
|
/milestone v1.30 |
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In order to adapt the existing test to the new validation rule introduced in #123273 that
status.startTimecannot be updated for an unsuspended job. The feature is still in alpha, but it is good to prepare to the agreed validation.The intention of the test is to verify the Job status can be updated by Update of Patch operations, not particular field to be updated.
Which issue(s) this PR fixes:
Tracking issue: kubernetes/enhancements#4368
Special notes for your reviewer:
The intention of the test was discussed with the API reviewers during the meeting discussing the label vs field approach. The note is second from the bottom point in the doc. Adjusting the test to modify a field that would pass the new validation rules was the proposed approach.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: