Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Bump images, dependencies and versions to go 1.22.1 and distroless iptables #123750

Merged
merged 1 commit into from Mar 6, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 6, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Bump images, dependencies and versions to go 1.22.1 and distroless iptables

Which issue(s) this PR fixes:

Part of kubernetes/release#3479

/assign @MadhavJivrajani @liggitt @xmudrii @saschagrunert
cc @kubernetes/release-managers

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with go 1.22.1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 6, 2024
@cpanato
Copy link
Member Author

cpanato commented Mar 6, 2024

@saschagrunert
Copy link
Member

The CI does not seem to be happy with the change.

@cpanato
Copy link
Member Author

cpanato commented Mar 6, 2024

/retest

@liggitt
Copy link
Member

liggitt commented Mar 6, 2024

update-go-workspace.sh verify is failing because it regenerates every time with the current go version and is expecting a diff of go1.22.1. I don't think we want that behavior... the go directive in that file is the minimum, we control our build toolchain version separately. cc @thockin

@liggitt
Copy link
Member

liggitt commented Mar 6, 2024

fix for the update-go-workspace.sh go stomping in #123759

@cpanato
Copy link
Member Author

cpanato commented Mar 6, 2024

fix for the update-go-workspace.sh go stomping in #123759

thank you

…ss iptables

Signed-off-by: cpanato <ctadeu@gmail.com>
@dims
Copy link
Member

dims commented Mar 6, 2024

/approve
/lgtm
/milestone v1.30
/area security

see announcement - https://groups.google.com/g/golang-announce/c/5pwGVUPoMbg/m/46oA5yPABQAJ

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 309d017de8cb0270581a5e4bb828cdd4728ebcf5

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit e062103 into kubernetes:master Mar 6, 2024
17 checks passed
@cpanato cpanato deleted the update-go branch March 7, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants