Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dra e2e: fix stack unwinding in helper function #123521

Merged
merged 1 commit into from Feb 27, 2024
Merged

dra e2e: fix stack unwinding in helper function #123521

merged 1 commit into from Feb 27, 2024

Commits on Feb 19, 2024

  1. dra e2e: fix stack unwinding in helper function 

    When failing inside the `ginkgo.By` callback function, skipping intermediate
stack frames didn't work properly because `ginkgo.By` itself and other internal
code is also on the stack.

To fix this, the code which can fail now runs outside of such a
callback. That's not a big loss, the only advantage of the callback was getting
timing statistics from Ginkgo which weren't used in practice.
    @pohly
    pohly committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    cb31809 View commit details
    Browse the repository at this point in the history