Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test for the scheduling queue for QueueingHint disabled #122311

Merged
merged 1 commit into from
Dec 16, 2023
Merged

add unit test for the scheduling queue for QueueingHint disabled #122311

merged 1 commit into from
Dec 16, 2023

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Dec 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

part of #122284 (comment)

Which issue(s) this PR fixes:

Fixes #122304

Special notes for your reviewer:

ref : https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/scheduler/internal/queue/scheduling_queue_test.go#L703

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2023
@nayihz
Copy link
Contributor Author

nayihz commented Dec 14, 2023

/assign @sanposhiho

sanposhiho
sanposhiho reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a quick review, but LGTM overall.

pkg/scheduler/internal/queue/scheduling_queue_test.go Show resolved Hide resolved
pkg/scheduler/internal/queue/scheduling_queue_test.go Outdated Show resolved Hide resolved
@sanposhiho
Copy link
Member

/retitle add unit test for the scheduling queue for QueueingHint disabled

@k8s-ci-robot k8s-ci-robot changed the title add unit test when SchedulerQueueingHints feature gate was dsiabled by default add unit test for the scheduling queue for QueueingHint disabled Dec 14, 2023
sanposhiho
sanposhiho reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the advice from the linter?
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/122311/pull-kubernetes-linter-hints/1735193912324132864

@nayihz
Copy link
Contributor Author

nayihz commented Dec 15, 2023

/test pull-kubernetes-unit

sanposhiho
sanposhiho approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e9520fdb1901c1de16edf29c88e0e8537411d6c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nayihz, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 162599d into kubernetes:master Dec 16, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

re-create unit tests for the scheduling queue for the cases QueueingHint disabled
3 participants
@nayihz @k8s-ci-robot @sanposhiho