-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "scheduler/nodeaffinity: reduce pod scheduling latency" #122285
Conversation
This reverts commit 1d88bf9.
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Dec 12 22:21:49 UTC 2023. |
/retest |
/assign @alculquicondor |
/hold |
Given #122289 is merged, it's OK to revert the change in the patch release. |
/unhold It's good to go now. I'll also cherry-pick to v1.29. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 84e88a2ba42cb147799d297ced94dab1f67fb0fe
|
/retest |
/retest |
1 similar comment
/retest |
Same question: |
…122285-upstream-release-1.29 Automated cherry pick of #122285: Revert "scheduler/nodeaffinity: reduce pod scheduling
This reverts commit 1d88bf9.
What type of PR is this?
/kind bug
/priority critical-urgent
/triage accepted
What this PR does / why we need it:
NodeAffinity QueueingHint may miss Node related events that make Pod schedulable because of preCheck.
It's similar to: #119177 (comment)
So:
In such scenarios, NodeAffinity returns
QueueSkip
to the event due to (2), because (2) is just a taint update, which looks unrelated to NodeAffinity.https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/plugins/nodeaffinity/node_affinity.go#L94-L131
Which issue(s) this PR fixes:
Temporal fix for #122284
Special notes for your reviewer:
@kubernetes/sig-scheduling-leads
If possible, we have to get this PR in v1.29, but the release date is very close.
The user impact is that sometimes Pods, which was rejected by NodeAffinity, could be stuck in unschedQ during max 5min even though a new Node is created.
Can we somehow include it in v1.29? or do we have to wait for the patch release.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: