New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: scheduler framework: support simulating cluster changes during autoscaling #120936
Conversation
…aling The assumption so far was that plugins which are active during cluster autoscaling can do their work exclusively based on the information maintained by cluster autoscaler about nodes and pods on those nodes. This assumption doesn't hold for plugins which need to observe and potentially modified other cluster state, like the dynamic resource allocation plugin. Such plugins need a way to do its own snapshotting of the cluster state at the start of a simulation and then update that snapshotting while the cluster autoscaler simulates the placement of pods on nodes. The new ClusterAutoScalerPlugin interface provides a mechanism for this. It is not used anywhere in kube-scheduler itself, but has to be defined here because plugins cannot get it from k8s.io/autoscaler (circular dependency) and creating a new repo seems overkill.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The assumption so far was that plugins which are active during cluster autoscaling can do their work exclusively based on the information maintained by cluster autoscaler about nodes and pods on those nodes. This assumption doesn't hold for plugins which need to observe and potentially modified other cluster state, like the dynamic resource allocation plugin.
Such plugins need a way to do its own snapshotting of the cluster state at the start of a simulation and then update that snapshotting while the cluster autoscaler simulates the placement of pods on nodes.
The new ClusterAutoScalerPlugin interface provides a mechanism for this. It is not used anywhere in kube-scheduler itself, but has to be defined here because plugins cannot get it from k8s.io/autoscaler (circular dependency) and creating a new repo seems overkill.
Which issue(s) this PR fixes:
Related-to: #118612
Special notes for your reviewer:
This needs to be reviewed in combination with the corresponding change in cluster autoscaler.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @mwielgus @alculquicondor @MaciekPytel