Skip to content

Commit

Permalink
fix the linter
Browse files Browse the repository at this point in the history
  • Loading branch information
mimowo committed Feb 14, 2024
1 parent b641555 commit ef74f41
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions pkg/controller/job/job_controller_test.go
Expand Up @@ -2406,9 +2406,13 @@ func TestSyncJobWhenManagedByLabel(t *testing.T) {
actual = job
return job, nil
}
sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job)
if err := sharedInformerFactory.Batch().V1().Jobs().Informer().GetIndexer().Add(job); err != nil {
t.Fatalf("error %v while adding the %v job to the index", err, klog.KObj(job))
}

manager.syncJob(context.TODO(), testutil.GetKey(job, t))
if err := manager.syncJob(context.TODO(), testutil.GetKey(job, t)); err != nil {
t.Fatalf("error %v while reconciling the job %v", err, testutil.GetKey(job, t))
}

if diff := cmp.Diff(tc.wantStatus, actual.Status); diff != "" {
t.Errorf("Unexpected job status (-want,+got):\n%s", diff)
Expand Down
2 changes: 1 addition & 1 deletion pkg/features/kube_features.go
Expand Up @@ -354,7 +354,7 @@ const (
// kep: https://kep.k8s.io/4368
// beta: v1.30
//
// Allows to deleted reconciliation of the Job to another controller.
// Allows to delegate reconciliation of a Job object to an external controller.
JobManagedByLabel featuregate.Feature = "JobManagedByLabel"

// owner: @mimowo
Expand Down

0 comments on commit ef74f41

Please sign in to comment.