Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[importer] Run in cluster #1882

Merged
merged 4 commits into from Mar 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
Expand Up @@ -334,7 +334,6 @@ importer-image-build:
$(PUSH) \
-f ./cmd/importer/Dockerfile ./

# Developers don't need to build this image, as it will be available as gcr.io/k8s-staging-kueue/importer
.PHONY: importer-image-push
importer-image-push: PUSH=--push
importer-image-push: importer-image-build
Expand Down
2 changes: 1 addition & 1 deletion cloudbuild.yaml
Expand Up @@ -27,7 +27,7 @@ steps:
args:
- importer-image-push
env:
- IMAGE_REGISTRY=gcr.io/$PROJECT_ID
- STAGING_IMAGE_REGISTRY=gcr.io/$PROJECT_ID
trasc marked this conversation as resolved.
Show resolved Hide resolved
- GIT_TAG=$_GIT_TAG
- EXTRA_TAG=$_PULL_BASE_REF
- DOCKER_BUILDX_CMD=/buildx-entrypoint
Expand Down
8 changes: 5 additions & 3 deletions cmd/importer/README.md
Expand Up @@ -100,7 +100,9 @@ After which, if `--dry-run=false` was specified, for each selected Pod the impor

#### Run in cluster

`cmd/importer/run-in-cluster` provides the necessary kustomize manifests needed to run the importer from within the cluster, In order to use them you should:
`cmd/importer/run-in-cluster` provides the necessary kustomize manifests needed to run the importer from within the cluster.

In order to use the manifests, you should:

1. Update the used image

Expand All @@ -119,15 +121,15 @@ And run
(cd cmd/importer/run-in-cluster && kustomize edit set image importer=<image:tag>)
```

2. Updated the importer args in `cmd/importer/run-in-cluster/importer.yaml`
2. Update the importer args in `cmd/importer/run-in-cluster/importer.yaml`
3. Update the mapping configuration in `cmd/importer/run-in-cluster/mapping.yaml`
4. Deploy the configuration:

```bash
kubectl apply -k cmd/importer/run-in-cluster/
```
trasc marked this conversation as resolved.
Show resolved Hide resolved

And check the logs
And check the logs

```yaml
kubectl -n kueue-importer logs kueue-importer -f
trasc marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion cmd/importer/run-in-cluster/importer.yaml
Expand Up @@ -12,7 +12,7 @@ spec:
- -n=ns1,ns2
- --queuemapping-file=/mapping.yaml
- --dry-run=false
- -v
- -vv
trasc marked this conversation as resolved.
Show resolved Hide resolved
volumeMounts:
- name: config
mountPath: /mapping.yaml
Expand Down