Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[importer] Run in cluster #1882

Merged
merged 4 commits into from Mar 22, 2024
Merged

[importer] Run in cluster #1882

merged 4 commits into from Mar 22, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Mar 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

[importer] Run in cluster

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 22, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 418336e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65fdc5b62accba000948d915

@trasc
Copy link
Contributor Author

trasc commented Mar 22, 2024

/test all

@trasc trasc marked this pull request as ready for review March 22, 2024 13:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2024
alculquicondor
alculquicondor reviewed Mar 22, 2024
View reviewed changes
cloudbuild.yaml Outdated Show resolved Hide resolved
Makefile
$(GO_BUILD_ENV) $(GO_CMD) build -ldflags="$(LD_FLAGS)" -o bin/importer cmd/importer/main.go

.PHONY: importer-image-build
importer-image-build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, can you add this target to the build presubmit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could

Makefile Outdated Show resolved Hide resolved
cmd/importer/README.md Outdated Show resolved Hide resolved
cmd/importer/README.md Show resolved Hide resolved
cmd/importer/run-in-cluster/deps.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is this autogenerated? If not, could it be using kubebuilder tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could do it .... but it might be overkill. my initial intent was to just use the kueue-controller-manager's SA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we just reference that or use a ln?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe yes but it will be too hacky.

cmd/importer/run-in-cluster/importer.yaml
@@ -0,0 +1,25 @@
apiVersion: v1
kind: Pod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a kubernetes Job instead, because it provides retries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pod will most likely fail due to a bad mapping, I don't see a value in retrying it.

cmd/importer/README.md Show resolved Hide resolved
cmd/importer/README.md Outdated Show resolved Hide resolved
cmd/importer/run-in-cluster/importer.yaml Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b57cf1529428a898db3967191e27b73174bc1a92

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f34e38 into kubernetes-sigs:main Mar 22, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 22, 2024
@trasc trasc deleted the importer-in-cluster branch March 22, 2024 18:17
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@trasc @vsoch
[importer] Run in cluster (kubernetes-sigs#1882)
6a1594a 
* [importer] Run in cluster

* [importer-image] Add a branch specific moving tag

* Review Remarks

* Review Remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mimowo mimowo Awaiting requested review from mimowo

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trasc @k8s-ci-robot @alculquicondor