Fix the naming convention in the config-features.yaml #7743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or in yq when yaml parsing happens Signed-off-by: Leo Li <leoli@redhat.com>
knative-prow
bot
added
the
approved
knative-prow
bot
added
size/S
…or in yq when yaml parsing happens Signed-off-by: Leo Li <leoli@redhat.com>
creydr
approved these changes
Mar 6, 2024
|
@Leo6Leo can you fix the unit test? |
Signed-off-by: Leo Li <leoli@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7743 +/- ##
=======================================
Coverage 69.11% 69.11%
=======================================
Files 339 339
Lines 19398 19398
=======================================
Hits 13406 13406
Misses 5330 5330
Partials 662 662 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
., we use-, otherwise it might cause error when using yqPre-review Checklist
Release Note
Docs