Fix the naming convention in the config-features.yaml (#7743)

* Fix the naming convention in the config-features.yaml, to prevent error in yq when yaml parsing happens Signed-off-by: Leo Li <leoli@redhat.com> * Fix the naming convention in the config-features.yaml, to prevent error in yq when yaml parsing happens Signed-off-by: Leo Li <leoli@redhat.com> * fix the failing unit tests Signed-off-by: Leo Li <leoli@redhat.com> --------- Signed-off-by: Leo Li <leoli@redhat.com>
knative · Mar 6, 2024 · 42da1e1 · 42da1e1
1 parent c9de4b5
commit 42da1e1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/pkg/apis/feature/flag_names.go b/pkg/apis/feature/flag_names.go
@@ -25,5 +25,5 @@ const (
 	TransportEncryption = "transport-encryption"
 	EvenTypeAutoCreate  = "eventtype-auto-create"
 	OIDCAuthentication  = "authentication-oidc"
-	NodeSelectorLabel   = "apiserversources.nodeselector."
+	NodeSelectorLabel   = "apiserversources-nodeselector-"
 )
diff --git a/pkg/apis/feature/testdata/config-features.yaml b/pkg/apis/feature/testdata/config-features.yaml
@@ -25,6 +25,6 @@ data:
     my-enabled-flag: "enabled"
     my-disabled-flag: "disabled"
     my-allowed-flag: "allowed"
-    apiserversources.nodeselector.testkey: testvalue
-    apiserversources.nodeselector.testkey1: testvalue1
-    apiserversources.nodeselector.testkey2: testvalue2
+    apiserversources-nodeselector-testkey: testvalue
+    apiserversources-nodeselector-testkey1: testvalue1
+    apiserversources-nodeselector-testkey2: testvalue2
diff --git a/pkg/reconciler/apiserversource/apiserversource_test.go b/pkg/reconciler/apiserversource/apiserversource_test.go
@@ -1089,8 +1089,8 @@ func TestReconcile(t *testing.T) {
 			Name: "Valid with nodeSelector",
 
 			Ctx: feature.ToContext(context.Background(), feature.Flags{
-				"apiserversources.nodeselector.testkey1": "testvalue1",
-				"apiserversources.nodeselector.testkey2": "testvalue2",
+				"apiserversources-nodeselector-testkey1": "testvalue1",
+				"apiserversources-nodeselector-testkey2": "testvalue2",
 			}),
 			Objects: []runtime.Object{
 				rttestingv1.NewApiServerSource(sourceName, testNS,

diff --git a/test/rekt/resources/configmap/config-features.yaml b/test/rekt/resources/configmap/config-features.yaml
@@ -11,7 +11,7 @@ data:
     my-enabled-flag: "enabled"
     my-disabled-flag: "disabled"
     my-allowed-flag: "allowed"
-    apiserversources.nodeselector.testkey: testvalue
-    apiserversources.nodeselector.testkey1: testvalue1
-    apiserversources.nodeselector.testkey2: testvalue2
+    apiserversources-nodeselector-testkey: testvalue
+    apiserversources-nodeselector-testkey1: testvalue1
+    apiserversources-nodeselector-testkey2: testvalue2