Sample App: Adding the knative function build for the sentiment analysis service #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
knative-prow
bot
added
the
approved
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Leo6Leo
changed the title
knative-prow
bot
added
do-not-merge/work-in-progress
Leo6Leo
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
Cali0707
reviewed
Mar 15, 2024
code-samples/eventing/bookstore-sample-app/ML-sentiment-analysis/README.md
Outdated
Show resolved
Hide resolved
…coming cloudEvent
knative-prow
bot
added
size/XL
Cali0707
reviewed
Mar 20, 2024
code-samples/eventing/bookstore-sample-app/ML-sentiment-analysis/README.md
Show resolved
Hide resolved
|
I agree, and since cold start is already something on the back of customer
mind while working with serverless, we should not add extra perception
Thank you,
-N
…On Wed, 20 Mar 2024 at 12:33, Calum Murray ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
code-samples/eventing/bookstore-sample-app/ML-sentiment-analysis/README.md
<#5904 (comment)>:
> + # Sleep for 3 seconds to simulate a long-running process
+ sleep(3)
I think since this is providing an example of how to build an app with
Knative it doesn't necessarily make sense to make it slower just to show
that some real world stuff could be slow, so my vote would be to remove it
(as long as everything still works without the sleep)
—
Reply to this email directly, view it on GitHub
<#5904 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISZCFBLFXZ7CTS63FH7PULYZG25JAVCNFSM6AAAAABEUF5TMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBZGQ2DCMRYHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
tico88612
reviewed
Mar 27, 2024
code-samples/eventing/bookstore-sample-app/ML-sentiment-analysis/README.md
Outdated
Show resolved
Hide resolved
Leo6Leo
changed the title
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
size/L
Leo6Leo
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
knative/func#2241 has been resolved. In order to make func invoke work correctly, readers need to install latest knative function when available. (release 1.14) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5889
Proposed Changes