Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App: ML service - Inappropriate language filter #5917

Closed
Leo6Leo opened this issue Mar 19, 2024 · 5 comments · Fixed by #5935
Closed

Sample App: ML service - Inappropriate language filter #5917

Leo6Leo opened this issue Mar 19, 2024 · 5 comments · Fixed by #5935
Assignees
Labels
good first issue help wanted kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 19, 2024

Problem

Create a container image that contains a python application that connected to a simple inappropriate language filter model. When container start running, the application should have the URL endpoint to pass in the input, and the output from the model should be returned as JSON.

The model will take the text comment as input, and tell whether the text is:

  • "good": which means doesn't contain any inappropriate language
  • "bad": which means does contain any inappropriate language

You can find more detail in the design doc here.

Persona:

Which persona is this feature for?
Administrators and developers

Exit Criteria

  • A container image that contains a python application that connected to a simple inappropriate language filter model
  • A detailed documentation that explains it and include the setup guide.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?
1-2

Additional context (optional)

@Leo6Leo Leo6Leo assigned Leo6Leo and unassigned Leo6Leo Mar 19, 2024
@Leo6Leo Leo6Leo added kind/good-first-issue Denotes an issue ready for a new contributor. good first issue help wanted labels Mar 19, 2024
@tico88612
Copy link
Contributor

/assign

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Mar 20, 2024

Hey @tico88612! Thanks for taking on this issue! Feel free to reach out for help if you have any questions!

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Mar 26, 2024

Hey @tico88612 , do you need any help with the issue?

@tico88612
Copy link
Contributor

tico88612 commented Mar 27, 2024

Hi @Leo6Leo, Sorry for the slow reply.

Should I follow PR #5904 to implement an Inappropriate language filter?

@Leo6Leo
Copy link
Member Author

Leo6Leo commented Mar 27, 2024

@tico88612 Yes, that's correct. Let do it in that way for now, but it might subject to change, as we might brainstorm more new ideas along the way.

But feel free to think about any new ways to implement it, as long as it can best demonstrate knative's feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants