Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample App: Notification Service: camel slack sink #5888
Sample App: Notification Service: camel slack sink #5888
Changes from 4 commits
f56b702
1d1716e
9908206
f6e8442
613436f
3f35a48
e88b102
c93a422
edc9e99
5d230a5
c443d26
404f365
e577254
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these, if you are going to say they are prerequisites, people will try and look up how to do them before continuing. It looks like you explain installing Camel K right below, so maybe you can remove this from prerequisites and instead just explain the installation below? I know that you are talking about needing the Camel K CLI installed as well as Camel-Kamelets, but I think you can mention those in the installation below with links to docs on how to install them, or alternatively add those links on how to install into this prerequisites section
For me, prerequisites is more of a section where you outline things you already need before continuing, not things that you will learn about in the section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, and I get your point. How does the new change I made look to you? I changed the structure a bit @Cali0707
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Leo6Leo what's the purpose of this file? Don't we have this same yaml in the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is the same content as the one in the README. I just have all the code in files as well, so readers can directly download all the code and run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the content of this one then? It looks a little out of sync with the one in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!! Thanks @Cali0707 ! I didn't realize that they are inconsistent.