Sample App: Notification Service: camel slack sink #5888
Conversation
knative-prow
bot
added
the
size/L
knative-prow
bot
added
the
approved
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @Cali0707 |
| - The Camel K CLI (`kamel`) installed on your local machine. | ||
| - Apache Camel-Kamelets Version 4.4.x or later. | ||
| - A Slack workspace with the ability to create incoming webhooks. You can follow the link here to learn more about how to set up the slack workspace. |
There was a problem hiding this comment.
For these, if you are going to say they are prerequisites, people will try and look up how to do them before continuing. It looks like you explain installing Camel K right below, so maybe you can remove this from prerequisites and instead just explain the installation below? I know that you are talking about needing the Camel K CLI installed as well as Camel-Kamelets, but I think you can mention those in the installation below with links to docs on how to install them, or alternatively add those links on how to install into this prerequisites section
For me, prerequisites is more of a section where you outline things you already need before continuing, not things that you will learn about in the section
There was a problem hiding this comment.
Sounds good, and I get your point. How does the new change I made look to you? I changed the structure a bit @Cali0707
code-samples/eventing/bookstore-sample-app/slack-sink/README.md
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/slack-sink/README.md
Outdated
Show resolved
Hide resolved
code-samples/eventing/bookstore-sample-app/slack-sink/README.md
Outdated
Show resolved
Hide resolved
…when the content is ready
code-samples/eventing/bookstore-sample-app/slack-sink/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Calum Murray <cmurray@redhat.com>
| apiVersion: camel.apache.org/v1 | ||
| kind: Pipe | ||
| metadata: | ||
| name: slack-sink-pipe | ||
| spec: | ||
| source: | ||
| ref: | ||
| kind: Broker | ||
| apiVersion: eventing.knative.dev/v1 | ||
| name: book-review-broker | ||
| properties: | ||
| type: new-review-comment | ||
| sink: | ||
| ref: | ||
| kind: Kamelet | ||
| apiVersion: camel.apache.org/v1 | ||
| name: slack-sink | ||
| properties: | ||
| channel: “#bookstore-owner” | ||
| webhookUrl: <Your Slack Web Hook to the channel above> |
There was a problem hiding this comment.
@Leo6Leo what's the purpose of this file? Don't we have this same yaml in the README?
There was a problem hiding this comment.
Yes, it is the same content as the one in the README. I just have all the code in files as well, so readers can directly download all the code and run.
There was a problem hiding this comment.
Could you update the content of this one then? It looks a little out of sync with the one in the readme
There was a problem hiding this comment.
Great catch!! Thanks @Cali0707 ! I didn't realize that they are inconsistent.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, Leo6Leo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5887
Proposed Changes