Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Investigating the flaky fileWatcher test #3750

Closed
wants to merge 2 commits into from
Closed

[WIP] Investigating the flaky fileWatcher test #3750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d9b8c
running 10 times to reproduce the error
Leo6Leo Mar 8, 2024
8b0d89d
Adding the Thread sleep
Leo6Leo Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/file/FileWatcher.java
View file
Open in desktop
Expand Up @@ -15,10 +15,8 @@
*/
package dev.knative.eventing.kafka.broker.core.file;

import static java.nio.file.StandardWatchEventKinds.ENTRY_CREATE;
import static java.nio.file.StandardWatchEventKinds.ENTRY_DELETE;
import static java.nio.file.StandardWatchEventKinds.ENTRY_MODIFY;
import static java.nio.file.StandardWatchEventKinds.OVERFLOW;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.File;
import java.io.IOException;
Expand All @@ -27,8 +25,8 @@
import java.nio.file.WatchService;
import java.util.Objects;
import java.util.concurrent.CountDownLatch;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import static java.nio.file.StandardWatchEventKinds.*;

/**
* This class is responsible for watching a given file and reports update or execute a trigger function.
Expand Down Expand Up @@ -128,6 +126,7 @@ public void run() {
WatchKey key;
try {
key = watcher.take();
Thread.sleep( 50 );
logger.debug("Contract updates");
} catch (InterruptedException e) {
break; // Thread.interrupt was invoked
Expand Down
1 change: 1 addition & 0 deletions ...plane/core/src/test/java/dev/knative/eventing/kafka/broker/core/file/FileWatcherTest.java
View file
Open in desktop
Expand Up @@ -43,6 +43,7 @@ public void tearDown() throws Exception {
}

@Test
@RepeatedTest(10)
public void testFileModification() throws Exception {
// Set up a counter to track how many times the trigger function is called
AtomicInteger counter = new AtomicInteger(0);
Expand Down