Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Investigating the flaky fileWatcher test #3750

Closed

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Mar 8, 2024

No description provided.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@knative-prow knative-prow bot requested review from matzew and pierDipi March 8, 2024 16:26
Copy link

knative-prow bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane labels Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.46%. Comparing base (7a3464c) to head (8b0d89d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3750      +/-   ##
============================================
+ Coverage     52.44%   52.46%   +0.01%     
  Complexity      874      874              
============================================
  Files           342      342              
  Lines         21415    21416       +1     
  Branches        284      284              
============================================
+ Hits          11231    11235       +4     
+ Misses         9274     9272       -2     
+ Partials        910      909       -1     
Flag Coverage Δ
java-unittests 74.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2024
Copy link

knative-prow bot commented Mar 8, 2024

@Leo6Leo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing-kafka-broker_main 8b0d89d link true /test build-tests
integration-tests_eventing-kafka-broker_main 8b0d89d link true /test integration-tests
upgrade-tests_eventing-kafka-broker_main 8b0d89d link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants