Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1155. Empty output subscribers query, who finish campaign #1175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −21
Open

Fix #1155. Empty output subscribers query, who finish campaign #1175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fae2a6
fix problem with emty output part of subscribers
saginsa Feb 4, 2023
5d2b2f4
one time get subscribers table
saginsa Mar 8, 2023
bcf4388
query style fix
saginsa Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 12 additions & 21 deletions queries.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,36 +688,27 @@ campLists AS (
LEFT JOIN campaign_lists ON (campaign_lists.list_id = lists.id)
WHERE campaign_lists.campaign_id = $1
),
subIDs AS (
SELECT DISTINCT ON (subscriber_lists.subscriber_id) subscriber_id, list_id, status FROM subscriber_lists
subs AS (
SELECT subscribers.* FROM subscribers
INNER JOIN subscriber_lists sl ON (subscribers.id = sl.subscriber_id)
LEFT JOIN campLists ON (campLists.list_id = sl.list_id)
WHERE
-- ARRAY_AGG is 20x faster instead of a simple SELECT because the query planner
-- understands the CTE's cardinality after the scalar array conversion. Huh.
list_id = ANY((SELECT ARRAY_AGG(list_id) FROM campLists)::INT[]) AND
status != 'unsubscribed' AND
subscriber_id > (SELECT last_subscriber_id FROM camps) AND
subscriber_id <= (SELECT max_subscriber_id FROM camps)
ORDER BY subscriber_id LIMIT $2
),
subs AS (
SELECT subscribers.* FROM subIDs
LEFT JOIN campLists ON (campLists.list_id = subIDs.list_id)
INNER JOIN subscribers ON (
subscribers.status != 'blocklisted' AND
subscribers.id = subIDs.subscriber_id AND

sl.list_id = ANY((SELECT ARRAY_AGG(list_id) FROM campLists)::INT[]) AND
sl.subscriber_id > (SELECT last_subscriber_id FROM camps) AND
sl.subscriber_id <= (SELECT max_subscriber_id FROM camps) AND
subscribers.status!='blocklisted' AND
(CASE
-- For optin campaigns, only e-mail 'unconfirmed' subscribers.
WHEN (SELECT type FROM camps) = 'optin' THEN subIDs.status = 'unconfirmed' AND campLists.optin = 'double'

WHEN (SELECT type FROM camps) = 'optin' THEN sl.status = 'unconfirmed' AND campLists.optin = 'double'
-- For regular campaigns with double optin lists, only e-mail 'confirmed' subscribers.
WHEN campLists.optin = 'double' THEN subIDs.status = 'confirmed'

WHEN campLists.optin = 'double' THEN sl.status = 'confirmed'
-- For regular campaigns with non-double optin lists, e-mail everyone
-- except unsubscribed subscribers.
ELSE subIDs.status != 'unsubscribed'
ELSE sl.status != 'unsubscribed'
END)
)
ORDER BY sl.subscriber_id LIMIT $2
),
u AS (
UPDATE campaigns
Expand Down