Fix #1155. Empty output subscribers query, who finish campaign #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think, that this fix haven't big performanse degradate, because subIds select work in same logical framework and conditions, and this is logical true. |
|
Thank you. Will test this on a large DB with millions of records over the weekend. |
knadh
reviewed
Mar 6, 2023
|
Any news on this? I have a very similar problem… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem Campaign goes to finished status without reaching all subscribers #1155.
It was in us, when we import big blacklisted base at start work with listmonk, and future lists have blocklisted subscribers but they wasn't unsubscribed. It was problem, because at first sample in query, find only unsubscribed emails, but in finish all unsubscribed finish transform in empty, because all of them is blacklisted. This element stop campaign, despite the remaining large number of emails on the mailing list, despite the remaining large number of emails on the mailing list.