New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning threshold to products, mail when below #91 #102
Open
thegcat
wants to merge
1
commit into
master
Choose a base branch
from
feature/91-threshold_warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
app/interactors/warn_if_product_quantity_below_threshold.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
class WarnIfProductQuantityBelowThreshold | ||
include Interactor | ||
|
||
def call | ||
btp = context.cart.cart_items.map(&:product). | ||
select(&:below_warning_threshold?). | ||
compact.uniq | ||
AdminMailer.btp_mail(btp: btp).deliver_later if btp.present? | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
class AdminMailer < ApplicationMailer | ||
def btp_mail(btp:) | ||
@btp = btp | ||
mail( | ||
to: ENV['KDV_ADMIN_MAIL'], | ||
subject: 'Some products are running low' | ||
) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
class ApplicationMailer < ActionMailer::Base | ||
default from: 'kdv@kif.rocks' | ||
layout 'mailer' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Moin, | ||
|
||
Folgende Produkte gehen bald leer, es sind nur noch übrig jeweils: | ||
|
||
<% @btp.each do |p| -%> | ||
* <%= p.name -%>: <%= p.quantity -%> | ||
<% end -%> | ||
|
||
Deine KDV Admins. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<!DOCTYPE html> | ||
<html> | ||
<head> | ||
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
<style> | ||
/* Email styles need to be inline */ | ||
</style> | ||
</head> | ||
|
||
<body> | ||
<%= yield %> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<%= yield %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
class AddThresholdToProducts < ActiveRecord::Migration[5.1] | ||
def change | ||
add_column :products, :warning_threshold, :integer | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
spec/interactors/warn_if_product_quantity_below_threshold_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
require 'rails_helper' | ||
|
||
RSpec.describe WarnIfProductQuantityBelowThreshold do | ||
describe '#call' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block has too many lines. [43/25] |
||
let(:interactor) { WarnIfProductQuantityBelowThreshold.new cart: cart } | ||
let(:context) { interactor.context } | ||
|
||
let(:products) do | ||
[ | ||
create(:product), | ||
create(:product) | ||
] | ||
end | ||
let(:cart_items) do | ||
[ | ||
create(:cart_item, quantity: 2, pricing: products[0].pricings.first), | ||
create(:cart_item, quantity: 1, pricing: products[1].pricings.first) | ||
] | ||
end | ||
let(:cart) { create :cart, cart_items: cart_items } | ||
|
||
before do | ||
allow(AdminMailer).to receive_message_chain(:btp_mail, :deliver_later) | ||
end | ||
before { interactor.call } | ||
|
||
context 'when there are no products below their thresholds' do | ||
it 'succeeds' do | ||
expect(context).to be_a_success | ||
end | ||
|
||
it 'doesn\'t send an email' do | ||
expect(AdminMailer).to_not have_received(:btp_mail) | ||
end | ||
end | ||
|
||
context 'when some products are below their threshold' do | ||
let(:products) do | ||
[ | ||
create(:product, quantity: 5, warning_threshold: 12), | ||
create(:product, quantity: 12, warning_threshold: 5), | ||
create(:product, quantity: 5, warning_threshold: 10) | ||
] | ||
end | ||
|
||
it 'succeeds' do | ||
expect(context).to be_a_success | ||
end | ||
|
||
it 'sends an email' do | ||
expect(AdminMailer).to have_received(:btp_mail). | ||
with(btp: [products[0]]) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block has too many lines. [45/25]