Add warning threshold to products, mail when below #91 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 15, 2017
| require 'rails_helper' | ||
|
|
||
| RSpec.describe WarnIfProductQuantityBelowThreshold do | ||
| describe '#call' do |
| @@ -0,0 +1,56 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe WarnIfProductQuantityBelowThreshold do | |||
spec/interactors/pay_cart_spec.rb
Outdated
| ] | ||
| end | ||
| let(:pricings) { products.collect { |p| p.pricings.first } } |
app/mailers/application_mailer.rb
Outdated
| default from: 'kdv@kif.rocks' | ||
| layout 'mailer' | ||
| end | ||
|
|
| AdminMailer.btp_mail(btp: btp).deliver_later if btp.present? | ||
| end | ||
| end | ||
|
|
| def call | ||
| btp = context.cart.cart_items.collect(&:product). | ||
| select { |p| p.below_warning_threshold? }. | ||
| compact.uniq |
There was a problem hiding this comment.
Align compact with context.cart.cart_items.collect(&:product). on line 5.
|
|
||
| def call | ||
| btp = context.cart.cart_items.collect(&:product). | ||
| select { |p| p.below_warning_threshold? }. |
There was a problem hiding this comment.
Align select with context.cart.cart_items.collect(&:product). on line 5.
Pass &:below_warning_threshold? as an argument to select instead of a block.
| include Interactor | ||
|
|
||
| def call | ||
| btp = context.cart.cart_items.collect(&:product). |
thegcat
force-pushed
the
feature/91-threshold_warnings
branch
from
c16d363
to
19f559c
Compare
thegcat
force-pushed
the
feature/91-threshold_warnings
branch
from
19f559c
to
50ab4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.