This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
#2719 #2752 #2810 GH Actions for CI Pipeline #2817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-kreuzberger-dtx
requested a review
from johannes-b
as a code owner
December 16, 2020 12:32
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
from
December 16, 2020 13:24
6b9f4de
to
d0f39cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
===========================================
+ Coverage 36.24% 55.66% +19.42%
===========================================
Files 161 2 -159
Lines 9370 309 -9061
Branches 197 0 -197
===========================================
- Hits 3396 172 -3224
+ Misses 5430 110 -5320
+ Partials 544 27 -517
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
10 times, most recently
from
December 16, 2020 13:58
be237df
to
ba929c6
Compare
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
12 times, most recently
from
December 16, 2020 17:15
9e07ca2
to
3c4f400
Compare
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
7 times, most recently
from
December 17, 2020 09:58
7d10e57
to
ae1cf36
Compare
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
from
December 17, 2020 10:05
ae1cf36
to
fd0cb69
Compare
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
from
December 17, 2020 10:14
fd0cb69
to
0a07fe4
Compare
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
from
December 17, 2020 11:22
f789490
to
d83c59f
Compare
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
christian-kreuzberger-dtx
changed the title
#2752 Added Docker Build as a GH action
#2719 #2752 #2810 GH Actions for CI Pipeline
Dec 17, 2020
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
christian-kreuzberger-dtx
force-pushed
the
feature/2752/docker_build
branch
from
December 17, 2020 14:16
f66e68b
to
b6e3693
Compare
johannes-b
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was referenced Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
Additional Changes:
.ci_env
file which is used to store all CI relevant environment variablesRegarding the Prepare job: This checks the repo for changes and other stuff, and prepares environment variables for other jobs, namely:
BUILD_EVERYTHING
- indicates that everything should be built (cli, docker images, helm chart)BUILD_{DIRNAME}
- indicates that only a certain directory should be built (e.g., for PRs where only the api or the cli was touched)BRANCH
,GIT_SHA
,DATETIME
VERSION
based onrelease-x.y.z
), thenVERSION=x.y.z
VERSION=${NEXTTAG}-dev-PR-{PRID}
VERSION=${NEXTTAG}-dev
Note 1: Due to a problem with Unit tests for CLI on Windows I had to disable them
Note 2: Due to maintenance of MacOS runners I had to disable everything related to MacOS for now actions/runner-images#2247
Docker Images are automatically pushed to DockerHub.
Everything else (CLI build, Helm Chart) is currently only pushed as an artifact of the workflow.
I'll create follow-up issues:
dev
(orlatest
) release which stores the CLI and Helm-Chart such that it can be directly downloadedSigned-off-by: Christian Kreuzberger christian.kreuzberger@dynatrace.com