Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

#2719 #2752 #2810 GH Actions for CI Pipeline #2817

Merged
merged 4 commits into from Dec 17, 2020

Conversation

christian-kreuzberger-dtx
Copy link
Member

This PR addresses the following issues:

Additional Changes:

  • I've introduced a .ci_env file which is used to store all CI relevant environment variables
    • I've cleaned certain bash scripts that were used for travis-ci before
  • I've created a single "CI Workflow" that handles all the three issues linekd above, as well as unit tests

image

Regarding the Prepare job: This checks the repo for changes and other stuff, and prepares environment variables for other jobs, namely:

  • BUILD_EVERYTHING - indicates that everything should be built (cli, docker images, helm chart)
  • BUILD_{DIRNAME} - indicates that only a certain directory should be built (e.g., for PRs where only the api or the cli was touched)
  • Several metadata like BRANCH, GIT_SHA, DATETIME
  • One important thing: We autogenerate VERSION based on
    • If it is a push on a release-branch (e.g., release-x.y.z), then VERSION=x.y.z
    • Else, we determine the last "tag" and increase the patch level, e.g., from 0.7.3 to 0.7.4
      • If it is a Pull Request, then VERSION=${NEXTTAG}-dev-PR-{PRID}
      • If it is a push on master, then VERSION=${NEXTTAG}-dev

Note 1: Due to a problem with Unit tests for CLI on Windows I had to disable them
Note 2: Due to maintenance of MacOS runners I had to disable everything related to MacOS for now actions/runner-images#2247

Docker Images are automatically pushed to DockerHub.
Everything else (CLI build, Helm Chart) is currently only pushed as an artifact of the workflow.

I'll create follow-up issues:

  1. Automatically create a dev (or latest) release which stores the CLI and Helm-Chart such that it can be directly downloaded
  2. Automatically create a release draft for changes on release branches
  3. Enable MacOS builds again once maintenance is complete
  4. Move certain "bash scripts" into a separate re-usable (for keptn-contrib/sandbox) GH action

Signed-off-by: Christian Kreuzberger christian.kreuzberger@dynatrace.com

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #2817 (4947121) into master (09faf22) will increase coverage by 19.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2817       +/-   ##
===========================================
+ Coverage   36.24%   55.66%   +19.42%     
===========================================
  Files         161        2      -159     
  Lines        9370      309     -9061     
  Branches      197        0      -197     
===========================================
- Hits         3396      172     -3224     
+ Misses       5430      110     -5320     
+ Partials      544       27      -517     
Flag Coverage Δ
moduleA ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice/event_handler/configure_monitoring_handler.go
helm-service/pkg/helm/test_util.go
cli/cmd/get_event_approvalTriggered.go
cli/cmd/update.go
helm-service/pkg/mesh/ingress_config.go
cli/cmd/generate_docs.go
...ouse-service/event_handler/evaluate_sli_handler.go
cli/cmd/upgrade.go
..._components/ktb-markdown/ktb-markdown.component.ts
bridge/client/app/_models/http-progress-state.ts
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a99a0...b6e3693. Read the comment docs.

@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/2752/docker_build branch 10 times, most recently from be237df to ba929c6 Compare December 16, 2020 13:58
@christian-kreuzberger-dtx christian-kreuzberger-dtx marked this pull request as draft December 16, 2020 14:06
@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/2752/docker_build branch 12 times, most recently from 9e07ca2 to 3c4f400 Compare December 16, 2020 17:15
@keptn keptn deleted a comment from github-actions bot Dec 16, 2020
@keptn keptn deleted a comment from github-actions bot Dec 16, 2020
@keptn keptn deleted a comment from github-actions bot Dec 16, 2020
@keptn keptn deleted a comment from github-actions bot Dec 16, 2020
@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/2752/docker_build branch 7 times, most recently from 7d10e57 to ae1cf36 Compare December 17, 2020 09:58
@keptn keptn deleted a comment from github-actions bot Dec 17, 2020
@keptn keptn deleted a comment from github-actions bot Dec 17, 2020
@keptn keptn deleted a comment from github-actions bot Dec 17, 2020
@keptn keptn deleted a comment from github-actions bot Dec 17, 2020
@keptn keptn deleted a comment from github-actions bot Dec 17, 2020
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@christian-kreuzberger-dtx christian-kreuzberger-dtx marked this pull request as ready for review December 17, 2020 12:18
@christian-kreuzberger-dtx christian-kreuzberger-dtx changed the title #2752 Added Docker Build as a GH action #2719 #2752 #2810 GH Actions for CI Pipeline Dec 17, 2020
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
Copy link
Member

@johannes-b johannes-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants