Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

#2719 Create GH Action for building the CLI #2795

Closed
wants to merge 1 commit into from

Conversation

christian-kreuzberger-dtx
Copy link
Member

This PR introduces a GitHub Action/Workflow that builds the CLI and uploads it as an artifact to the action itself (not to gcloud for now).

Note: The release step is not fully implemented yet. CLI is currently uploaded to GH actions instead of google cloud, but I guess that's a good thing.

In addition, I've removed all scripts that were used to build the CLI via travis-ci previously.

New Features

  • Build CLI on the operating system it is meant for (windows, linux, macos)
  • Upload CLI build artifacts via GH actions

GH Actions

Looks as follows:
gh-action-step1-wip

Build CLI on {Linux, Windows, MacOS}

This builds the cli on the target platform, and uploads an artifact to GitHub.

Release Keptn

Not implemented yet, but here is the idea

image

This is only triggered for release branches (e.g., release-0.8.0).
It downloads the previously built artifact, creates a draft release, and uploads the CLI assets to the draft release.

The end result of this step is a draft release with up2date CLI binaries (packed as .tar.gz):
image

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #2795 (8ef9831) into master (09faf22) will decrease coverage by 0.38%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
- Coverage   36.24%   35.85%   -0.39%     
==========================================
  Files         161      158       -3     
  Lines        9370     9189     -181     
  Branches      197      197              
==========================================
- Hits         3396     3295     -101     
+ Misses       5430     5377      -53     
+ Partials      544      517      -27     
Flag Coverage Δ
moduleA 22.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/handlers/evaluation.go 0.00% <0.00%> (ø)
cli/cmd/root.go 19.29% <ø> (-2.74%) ⬇️
helm-service/controller/action_handler.go 85.71% <ø> (-0.21%) ⬇️
helm-service/controller/delete_handler.go 87.80% <ø> (-0.30%) ⬇️
helm-service/controller/deployment_handler.go 33.65% <ø> (-0.64%) ⬇️
helm-service/controller/onboarder.go 89.85% <ø> (-0.08%) ⬇️
helm-service/controller/release_handler.go 22.32% <ø> (-0.69%) ⬇️
mongodb-datastore/handlers/events.go 23.38% <0.00%> (ø)
cli/cmd/configure_monitoring.go 41.89% <8.00%> (-15.81%) ⬇️
cli/pkg/credentialmanager/handler.go 13.04% <28.00%> (+2.69%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ba0b4...2fb4af1. Read the comment docs.

@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/2719/gh_action_cli branch 7 times, most recently from 36c5669 to 97705e3 Compare December 11, 2020 13:56
@christian-kreuzberger-dtx christian-kreuzberger-dtx linked an issue Dec 11, 2020 that may be closed by this pull request
4 tasks
@christian-kreuzberger-dtx christian-kreuzberger-dtx force-pushed the feature/2719/gh_action_cli branch 6 times, most recently from 7d037d1 to 8ef9831 Compare December 14, 2020 09:28
Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@christian-kreuzberger-dtx
Copy link
Member Author

Building on MacOS ic currently not working due to a Datacenter upgrade: actions/runner-images#2247
Though we can still merge this.

@christian-kreuzberger-dtx
Copy link
Member Author

No longer needed, superseeded by #2817

@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the feature/2719/gh_action_cli branch December 17, 2020 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard-dependency of MacOS builds in travis-ci
2 participants