fix: Validates New Relic provider api url has https #1152

[KanvaBhatia]

Closes #1152

📑 Description

Added a validation that the api url starts with 'https' in validate_config of NewrelicProvider.

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

ℹ Additional Information

Old behaviour -
Earlier it used to show this error instead of validating url.

New -
Added https validation in the config, hence this meaningful error_msg.

• I am not sure if this is the expected fix.

Thanks

[vercel]

@KanvaBhatia is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

[talboren]

@KanvaBhatia I think we should adjust frontend to accept different errors (not only scope validation) from the backend to display the error message you return from the URL validation properly. Are you up for fixing that too?

[KanvaBhatia]

Sure, here's what I am thinking -

Here, status codes 409 and 412 are handled with provider already existing and invalid scopes respectively.

https://github.com/keephq/keep/blob/67a92f809b4ca45e0c2684e9b7504169d2757ec0/keep-ui/app/providers/provider-form.tsx#L290C5-L320C5

Whenever a provider throws a ProviderException or ProviderConfigException, it gets stuck here -

https://github.com/keephq/keep/blob/67a92f809b4ca45e0c2684e9b7504169d2757ec0/keep/api/routes/providers.py#L555C3-L557C6

Possible solution -
Backend - Add a try/except block around the ProvidersFactory.get_provider call and catch ProviderException and ProviderConfigException. Then, raise an HTTPException with another status code (maybe 400?).

Frontend - Handle the response code 400 also along with with 409 and 412 in a similar way as done above.

[talboren]

@KanvaBhatia sounds perfect! Looking forward to reviewing this change

[KanvaBhatia]

Added the changes @talboren. Please review.

[talboren]

LGTM! @KanvaBhatia mind adding a screenshot of how it looks before I merge it in?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
keep	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 2:34pm

[KanvaBhatia]

Sure @talboren here's how it'll look like -

If any other Provider throws ProviderException or ProviderConfigException, that exception's respective message will also be displayed similarly.

For example, for PagerdutyProvider similar thing was happening which is now displayed like this -