fix: Validates New Relic provider api url has https #1152 (#1172)

keep-ui/app/providers/provider-form.tsx

@@ -297,6 +297,9 @@ const ProviderForm = ({
         if (!response.ok) {
           // If the response is not okay, throw the error message
           return response_json.then((errorData) => {
+            if (response.status === 400) {
+              throw `${errorData.detail}`;
+            }
             if (response.status === 409) {
               throw `Provider with name ${formValues.provider_name} already exists`;
             }

keep/api/routes/providers.py

@@ -4,6 +4,8 @@
 import time
 import uuid
 from typing import Callable, Optional
+from keep.exceptions.provider_config_exception import ProviderConfigException
+from keep.exceptions.provider_exception import ProviderException
 
 import sqlalchemy
 from fastapi import APIRouter, Body, Depends, HTTPException, Request
@@ -552,9 +554,15 @@ async def install_provider(
 
     # Instantiate the provider object and perform installation process
     context_manager = ContextManager(tenant_id=tenant_id)
-    provider = ProvidersFactory.get_provider(
-        context_manager, provider_id, provider_type, provider_config
-    )
+    try:
+        provider = ProvidersFactory.get_provider(
+            context_manager, provider_id, provider_type, provider_config
+        )
+    except (ProviderException, ProviderConfigException) as e:
+        raise HTTPException(
+            status_code=400,
+            detail=str(e)
+            )
 
     validated_scopes = validate_scopes(provider)
 

keep/providers/newrelic_provider/newrelic_provider.py

@@ -124,8 +124,14 @@ def validate_config(self):
         Raises:
             ProviderConfigException: user or account is missing in authentication.
             ProviderConfigException: private key
+            ProviderConfigException: new_relic_api_url must start with https
         """
         self.newrelic_config = NewrelicProviderAuthConfig(**self.config.authentication)
+        if (
+            self.newrelic_config.new_relic_api_url
+            and not self.newrelic_config.new_relic_api_url.startswith("https")
+        ):
+            raise ProviderConfigException("New Relic API URL must start with https", self.provider_id)
 
     def __make_add_webhook_destination_query(self, url: str, name: str) -> dict:
         query = f"""mutation {{