Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new relic validate the api URL is valid URL (starts with https) #1152

Closed
shahargl opened this issue Apr 30, 2024 · 2 comments · Fixed by #1172
Closed

new relic validate the api URL is valid URL (starts with https) #1152

shahargl opened this issue Apr 30, 2024 · 2 comments · Fixed by #1172
Labels
Bug Something isn't working Good First Issue Good for newcomers Provider Providers related issues

Comments

@shahargl
Copy link
Member

No description provided.

@talboren talboren added Bug Something isn't working Good First Issue Good for newcomers Provider Providers related issues labels May 3, 2024
@KanvaBhatia
Copy link
Contributor

Hey, may I help with this issue?

@talboren
Copy link
Member

@KanvaBhatia We should validate the API url provided to new relic provider is a valid URL.
It can be done using the validate_config of NewrelicProvider

KanvaBhatia added a commit to KanvaBhatia/keep that referenced this issue May 13, 2024
@KanvaBhatia
Fixes keephq#1152
2c0f4f6
@KanvaBhatia KanvaBhatia mentioned this issue May 13, 2024
Merged
4 tasks
talboren pushed a commit that referenced this issue May 15, 2024
@KanvaBhatia
fix: Validates New Relic provider api url has https #1152 (#1172)
172d401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Good First Issue Good for newcomers Provider Providers related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Validates New Relic provider api url has https #1152 KanvaBhatia/keep
3 participants
@shahargl @KanvaBhatia @talboren