New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for 'prefers-color-scheme' save our eyes @ night #858
base: main
Are you sure you want to change the base?
add support for 'prefers-color-scheme' save our eyes @ night #858
Conversation
@pdmosses could I get your opinion on how this impacts your Combination PR + the general dark mode work that you've done? |
2a42f4f
to
6834c00
Compare
@mattxwang the Combination PR #578 doesn't include automatic switching because #464 and #560 are alternative ways of fixing issue #234, and I didn't know which would finally be merged. In contrast to #464 and #560, the present PR doesn't update the color scheme on open pages until they are manually reloaded, I think? It's also not configurable. Perhaps issue #234 is the best place to discuss the pros and cons of the alternative PRs. |
It is not configurable. Yes. I proposed this as a way. |
6834c00
to
bc539d2
Compare
Okay, I think that this is
I'm going to label this PR as needs discussion. I'm not particularly well-versed in how JTD handles dark mode and will need to do a bit more reading; if another maintainer wants to take point on leading the color theme discussion, that would be great. |
Thoughts: |
bc539d2
to
a98ecd6
Compare
I tried running this PR in my fork and noticed that it is necessary to modify this script In https://github.com/simonebortolin/just-the-docs/tree/prefers-color-scheme I have made a fix for the script that after the change in question at this PR no longer works |
Left a comment in #234 explaining what's necessary to get this in a mergeable state! Happy to have anybody take it on, and I can review it, etc. |
Please consider changing the world of github pages and other consumers of template to save our vision. (-: