Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds automatic theme switching with optional toggle #1328

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattxwang
Copy link
Member

Draft as I continue working on this. I intend to tidy up and merge this in first-party.

Builds off of #1086, #1099, #560, #858. Closes #234.

@mattxwang
Copy link
Member Author

mattxwang commented Aug 23, 2023

Note to myself (and for anybody following along):

  • the flashes of unstyled content are pretty bad and persistent in-between pages. perhaps I'll need to rethink the broad-stroke approach, but I'm optimistic I can do some fine-tuning to resolve this.

Still left:

  • broadly: incorporate the review comments i made in Implement toggle color scheme, automatic theme mode #1086
  • resolve (or mitigate) said flashes
  • proper licensing of icons
  • properly test each combination of options
  • fix accessibility issues on button toggles / state
  • potentially clean up JS code
  • all the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support system-/browser-level dark mode
1 participant