add npm run build:css #1436
Merged
add npm run build:css #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What an improvement. It looks like the bower fetch still needs to be run prior to building CSS. |
minrk
force-pushed
the
less-py-js-py-js-less
branch
3 times, most recently
from
ba36231
to
db0b5be
Compare
setup.py css is just an alias for this, so there should be no more calls back to Python from npm run build:anything
pip install runs these steps
minrk
force-pushed
the
less-py-js-py-js-less
branch
from
db0b5be
to
f0352f6
Compare
|
After a bit of fiddling, this works now. less-2.7 fixes compatibility with node-6, but introduces a sourcemap bug (less/less.js#2896). We should upgrade LESS and restore source maps once they ship 2.7.1 with the fix. |
|
Great! On Sun, May 8, 2016 at 9:03 AM, Kyle Kelley notifications@github.com
Brian E. Granger |
|
@minrk 2.7.1 is available by now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py css is just an alias for this, so there should be no more calls back to Python from npm run build:anything
closes #1433