Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor npm run build:css #1433

Closed
Carreau opened this issue May 6, 2016 · 9 comments · Fixed by #1436
Closed

refactor npm run build:css #1433

Carreau opened this issue May 6, 2016 · 9 comments · Fixed by #1436
Projects
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented May 6, 2016

It is ridiculously slow, and the step it takes are also ridiculous as:

  • npm run build:css
    • call python setup.py css
      • that call jsdeps
        • that call npm install (to get bower)
        • that call npm run
          • and call bower install
    • then build the css by calling less.

Like really ? Asking the build the css invoke 3 different installation programs in 2 different languages. The build itself take a fraction of a second, for 2 files.

@takluyver
Copy link
Member

We need some shell scripting, a Makefile, and a couple of scripts written in lolcode somewhere in that toolchain. How are we meant to be web 2.5 with only two languages?

@rgbkrk
Copy link
Member

rgbkrk commented May 6, 2016

Wow that's painful.

I'm assuming this would look better:

  • npm run build:css
    • Builds the CSS by calling less

I'm assuming this project would need to get off bower, switch to full npm usage, and be reliant on npm scripts.

@blink1073
Copy link
Member

Getting off of bower would rely on better versions of requirejs and mathjax npm packages.

@blink1073
Copy link
Member

As in, the requirejs package does not currently play well with webpack.

@takluyver
Copy link
Member

We have told quite a few people to use python setup.py css js, so those should probably keep working, however it works internally.

@minrk
Copy link
Member

minrk commented May 7, 2016

setup css/js can call npm run build, but npm run x probably shouldn't call setup.py.

@minrk minrk added this to the 5.0 milestone May 7, 2016
@minrk
Copy link
Member

minrk commented May 7, 2016

#1436 removes the js->python call.

I still wish that webpack, etc. (everything, really) used Makefile-style detection to determine if builds need to run again, because unnecessary webpack rebuilds take a really long time.

@blink1073
Copy link
Member

Looking again, the npm packages for requirejs abd bower are self-contained, so they could be fetched via as npm packages and then served in-place or move the files to another location for serving.

@Carreau
Copy link
Member Author

Carreau commented May 8, 2016

Thanks.

I still wish that webpack, etc. (everything, really) used Makefile-style detection to determine if builds need to run again, because unnecessary webpack rebuilds take a really long time.

Are you going to rewrite a javascript building tool ? But agree, even if not based on datetime at least invalidate only part of the build graph when content hash changes...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5.0
Closed issues
Development

Successfully merging a pull request may close this issue.

5 participants