Enable VOSK Transcription #1343

janonym1 · 2022-07-05T09:50:27Z

this creates 2 (maybe) new ENV variables to allow for easier VOSK integration. Per default, it is assumed GCLOUD is always used and that makes it hard(er) to set up VOSK within docker-jitsi-meet

I still need to add the GCLOUD check and set for the ENV GOOGLE_APPLICATION_CREDENTIALS /config/key.json within the run script (jigasi/rootfs/etc/services.d/jigasi/run) but I am not sure how to best approach this. Maybe lets define an additional variable (ENABLE_GCLOUD_TRANSCRIPTION) and use that?

ENABLE_VOSK and VOSK_SERVER

when checking for empty GLCOUD credentials, also check if VOSK is disabled first

janonym1 · 2022-07-05T10:04:17Z

I added a new var ENABLE_GCLOUD_TRANSCRIPTION but I am not sure, if my code at jigasi/rootfs/etc/services.d/jigasi/run seting the GCLOUD ENV for the key.json is working as intended

janonym1 · 2022-07-05T10:08:05Z

I also am not sure, if it would be better/nicer if we can chain the check for the GCLOUD creds in the 10-config:

I wanted to AND together the following checks:
if [[ ($ENABLE_TRANSCRIPTIONS -eq 1 || $ENABLE_TRANSCRIPTIONS == "true") && ($ENABLE_VOSK -eq 0 || $ENABLE_VOSK == "false") && ($ENABLE_GCLOUD_TRANSCRIPTION -eq 1 || $ENABLE_GCLOUD_TRANSCRIPTION == "true") ]] but that isnt working as I imagined it. I assume I am misunderstanding some syntaxes here?

jigasi/rootfs/etc/cont-init.d/10-config

jigasi/rootfs/defaults/sip-communicator.properties

jigasi.yml

jigasi/rootfs/etc/services.d/jigasi/run

janonym1

updated the requested changes

debendraoli · 2022-08-21T06:08:02Z

Is there anything left to do? I would be happy to help.

It would be very useful when this gets merged. Thanks

janonym1 · 2022-08-22T09:37:22Z

Is there anything left to do? I would be happy to help.

It would be very useful when this gets merged. Thanks

I updated the requested changes (e.g. the variablenaming ENABLE_VOSK_TRANSCRIPTION) but I need to test it out on my testsystem first, which I unfortunately didnt get around to yet. If I botched up something, I also break the GCLOUD transcription ability, which more users seem to use than VOSK :)

Also I am not sure about the logic, that checks if transcriptions are on (but not gcloud) which I will get around to next week hopefully

charles-zablit · 2022-10-05T14:43:53Z

Hi, is there any update on this, and is there anything I can do to help?

HarHarLinks

it seems to me one variable was missed when renaming

jigasi/rootfs/etc/cont-init.d/10-config

rouaidakacem · 2022-11-30T09:49:08Z

@janonym1 is there an update on this ? Would love to help if necessary.

HarHarLinks · 2022-11-30T09:53:42Z

@debendraoli @charles-zablit @rouaidakacem and everyone else asking to help: could you test this PR and report if it works, and in case you have to make any changes, which ones? Because even with my proposed change, I can't get this to work.

jigasi/rootfs/defaults/sip-communicator.properties

Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>

saiflakhani · 2023-09-11T13:31:23Z

Been patiently waiting for this, hoping to see this in a release soon! Would love to help/test if there's an update on this

saghul · 2023-09-11T13:34:49Z

There is currently a conflict that needs to be fixed.

loelkes · 2024-01-30T19:45:52Z

Hi @saghul What needs to be done here? I would like to help. It looks like the changes you requested have not been reviewed by you. Or have I missed something?

How can I/we help to get this merged?

saghul · 2024-01-31T06:58:20Z

Yep, conflicts are yet to be solved.

loelkes · 2024-01-31T07:40:29Z

@saghul I understand that. But from what I can see, the changes you requested have been made but not reviewed. Can you review them and point out the remaining conflicts?

I don't have write access here, so all I could do was create a new branch/PR to address the conflicts there.

saghul · 2024-01-31T12:30:09Z

Please do that. I can't merge the PR as is, even if the feedback was addressed, because there are conflicts.

janonym1 · 2024-01-31T13:12:39Z

Sorry, I must have overlooked the activity here. I solved the conflicts but I think I have a bug somehwere in the logic. Let me look for my hardcoded values (since it worked for me before) and crosscheck with the effective values here

saghul · 2024-02-01T10:55:02Z

jigasi.yml

@@ -12,6 +12,8 @@ services:
            - ${CONFIG}/transcripts:/tmp/transcripts:Z
        environment:
            - ENABLE_AUTH
+            - ENABLE_GCLOUD_TRANSCRIPTION


This change is not backwards compatible. I'd say we should either repurpose ENABLE_TRANSCRIPTIONS to take a boolean (default to gcloud) or the type of transcription.

Alternatively some TRANSCRIPTION_BACKEND_TYPE which one could set to google or vosk

saghul · 2024-02-01T10:56:45Z

jigasi/rootfs/etc/services.d/jigasi/run

@@ -1,4 +1,7 @@
 #!/usr/bin/with-contenv bash
+if [[ -f /config/key.json ]]; then


Also check the transcriber type I think, simpler for testing switching between them.

saghul · 2024-02-01T10:57:45Z

jigasi/rootfs/defaults/sip-communicator.properties

@@ -8,6 +8,9 @@
 {{ $XMPP_PORT := .Env.XMPP_PORT | default "5222" -}}
 {{ $XMPP_SERVER := .Env.XMPP_SERVER | default "xmpp.meet.jitsi" -}}
 {{ $XMPP_SERVERS := splitList "," $XMPP_SERVER -}}
+{{ $ENABLE_VOSK_TRANSCRIPTION := .Env.ENABLE_VOSK_TRANSCRIPTION | default "0" | toBool  -}}
+{{ $ENABLE_GCLOUD_TRANSCRIPTION := .Env.ENABLE_GCLOUD_TRANSCRIPTION | default "0" | toBool  -}}
+{{ $VOSK_SERVER := .Env.VOSK_SERVER}}


This is unnecessary if you are not going to apply any transformation, you can use .Env.VOSK_SERVER directly.

zobadaniel · 2024-02-07T13:08:45Z

I have a simlar patch, so I'd rather 👍 this than to post my own. I am also willing to help in order to get this merged.

janonym1 · 2024-03-27T13:49:06Z

I forgot to add, that you have to have a working SIP setup (server+account) and config for VOSK to work.
Should I just assume it is setup or make a check (e.g. if JIGASI_SIP_URI is set)?

I also do not seem to get around the GCLOUD restriction; it needs to have a jigasi/config/key.json with valid credentials even when GCLOUD is deactivated. I am not sure how to get around this, maybe mock the credentials?

damencho · 2024-03-27T14:03:02Z

I forgot to add, that you have to have a working SIP setup (server+account) and config for VOSK to work.
Should I just assume it is setup or make a check (e.g. if JIGASI_SIP_URI is set)?

This is not a jigasi issue, this is configuration issue and should be fixed, maybe in this PR?

saghul · 2024-03-27T16:59:02Z

I think I fixed that already. If you set ENABLE_TRANSCRIPTIONS the sip config is skipped now.

janonym1 added 7 commits July 5, 2022 11:44

Jigasi: remove GCLOUD ENV from Dockerfile

f0a8aaa

add 2 new VOSK ENV variables

6562710

ENABLE_VOSK and VOSK_SERVER

check also against VOSK_ENABLED

ceb857c

when checking for empty GLCOUD credentials, also check if VOSK is disabled first

add 2 new VOSK related ENV vars

afd6c09

new ENABLE_GCLOUD env var

4159de3

add gcloud var and define defaults

e4b74d6

set GLCOUD env for key.json

b13ab69

janonym1 mentioned this pull request Jul 5, 2022

Vosk Configuration Support #1253

Open

saghul requested changes Jul 5, 2022

View reviewed changes

jigasi/rootfs/etc/cont-init.d/10-config Outdated Show resolved Hide resolved

jigasi/rootfs/defaults/sip-communicator.properties Outdated Show resolved Hide resolved

jigasi.yml Outdated Show resolved Hide resolved

jigasi/rootfs/etc/services.d/jigasi/run Outdated Show resolved Hide resolved

janonym1 added 5 commits July 5, 2022 17:13

Update jigasi.yml

df5b723

Update sip-communicator.properties

1ee6cfd

Update 10-config

57702ae

Update run

7fabc08

use export for global ENV

5b81e86

janonym1 commented Jul 6, 2022

View reviewed changes

janonym1 requested a review from saghul July 6, 2022 08:39

HarHarLinks suggested changes Nov 24, 2022

View reviewed changes

jigasi/rootfs/etc/cont-init.d/10-config Outdated Show resolved Hide resolved

rouaidakacem reviewed Nov 30, 2022

View reviewed changes

jigasi/rootfs/defaults/sip-communicator.properties Show resolved Hide resolved

Update jigasi/rootfs/etc/cont-init.d/10-config

bc8a046

Co-authored-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>

krombel mentioned this pull request Dec 4, 2023

feat: add VOSK config #1420

Open

Merge branch 'master' into docker-jitsi-meet-VOSK

dd568fe

saghul requested changes Feb 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable VOSK Transcription #1343

Enable VOSK Transcription #1343

janonym1 commented Jul 5, 2022 •

edited

janonym1 commented Jul 5, 2022

janonym1 commented Jul 5, 2022 •

edited

janonym1 left a comment •

edited

debendraoli commented Aug 21, 2022

janonym1 commented Aug 22, 2022

charles-zablit commented Oct 5, 2022 •

edited

HarHarLinks left a comment

rouaidakacem commented Nov 30, 2022

HarHarLinks commented Nov 30, 2022 •

edited

saiflakhani commented Sep 11, 2023

saghul commented Sep 11, 2023

loelkes commented Jan 30, 2024

saghul commented Jan 31, 2024

loelkes commented Jan 31, 2024

saghul commented Jan 31, 2024

janonym1 commented Jan 31, 2024

saghul Feb 1, 2024

saghul Feb 1, 2024

saghul Feb 1, 2024

zobadaniel commented Feb 7, 2024

janonym1 commented Mar 27, 2024

damencho commented Mar 27, 2024

saghul commented Mar 27, 2024

		@@ -1,4 +1,7 @@
		#!/usr/bin/with-contenv bash
		if [[ -f /config/key.json ]]; then

Enable VOSK Transcription #1343

Are you sure you want to change the base?

Enable VOSK Transcription #1343

Conversation

janonym1 commented Jul 5, 2022 • edited

janonym1 commented Jul 5, 2022

janonym1 commented Jul 5, 2022 • edited

janonym1 left a comment • edited

Choose a reason for hiding this comment

debendraoli commented Aug 21, 2022

janonym1 commented Aug 22, 2022

charles-zablit commented Oct 5, 2022 • edited

HarHarLinks left a comment

Choose a reason for hiding this comment

rouaidakacem commented Nov 30, 2022

HarHarLinks commented Nov 30, 2022 • edited

saiflakhani commented Sep 11, 2023

saghul commented Sep 11, 2023

loelkes commented Jan 30, 2024

saghul commented Jan 31, 2024

loelkes commented Jan 31, 2024

saghul commented Jan 31, 2024

janonym1 commented Jan 31, 2024

saghul Feb 1, 2024

Choose a reason for hiding this comment

saghul Feb 1, 2024

Choose a reason for hiding this comment

saghul Feb 1, 2024

Choose a reason for hiding this comment

zobadaniel commented Feb 7, 2024

janonym1 commented Mar 27, 2024

damencho commented Mar 27, 2024

saghul commented Mar 27, 2024

janonym1 commented Jul 5, 2022 •

edited

janonym1 commented Jul 5, 2022 •

edited

janonym1 left a comment •

edited

charles-zablit commented Oct 5, 2022 •

edited

HarHarLinks commented Nov 30, 2022 •

edited