feat: add VOSK config #1420
Open
feat: add VOSK config #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krombel
reviewed
Dec 4, 2023
| @@ -157,6 +157,10 @@ net.java.sip.communicator.service.gui.ALWAYS_TRUST_MODE_ENABLED=true | |||
| org.jitsi.jigasi.ENABLE_TRANSCRIPTION=true | |||
| org.jitsi.jigasi.transcription.ENABLE_TRANSLATION=true | |||
| org.jitsi.jigasi.transcription.DIRECTORY=/tmp/transcripts | |||
| {{ if .Env.JIGASI_CUSTOM_TRANSCRIPTION_SERVICE | default "" | toBool }} | |||
There was a problem hiding this comment.
as in #1659 i would suggest to remove default "" | toBool
krombel
reviewed
Dec 4, 2023
| @@ -104,6 +104,11 @@ ETHERPAD_SKIN_VARIANTS="super-light-toolbar super-light-editor light-background | |||
| # SIP server transport | |||
| #JIGASI_SIP_TRANSPORT=UDP | |||
|
|
|||
| # Jigasi transcription service | |||
| #JIGASI_CUSTOM_TRANSCRIPTION_SERVICE=org.jitsi.jigasi.transcription.VoskTranscriptionService | |||
There was a problem hiding this comment.
For discussion:
Should the class be exposed to the environment?
I would go for vosk as value here and set the class in sip-communicator.properties if this string is vosk.
In this case we then could change the env name to JIGASI_TRANSCRIPTION_SERVICE and have it allow google which is the current default.
|
alternative PR for #1343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements configuration options to implement the changes of jitsi/jigasi#457.
It allows a user to have a preconfigured version of VOSK if they choose to use it.
Please let me know if there is anything I can do to improve this PR.