66 fix multi cluster envs #100
Conversation
jetstack-bot
added
do-not-merge/release-note-label-needed
terraform/Dockerfile
Outdated
| unzip /tmp/terraform-provider-awstag.zip && \ | ||
| rm /tmp/terraform-provider-awstag.zip && \ | ||
| mv terraform-provider-awstag /terraform/terraform-provider-awstag && \ | ||
| chmod +x /terraform/terraform-provider-awstag |
There was a problem hiding this comment.
Before we can merge this we need to verify the binary using GPG. I think it would make sense to use airworthy and verify both our custom awstag provider and the terraform binary.
| return nil | ||
| } | ||
|
|
||
| /*func resourceAwstagEC2TagUpdate(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
Can we get rid of this comment
|
@dippynark can you take a look at my comments. Again also the verify boilterplate is failing because we don't have the LICENSE headers in the newly added files |
|
@dippynark PR needs rebase |
jetstack-ci-bot
added
the
needs-rebase
There was a problem hiding this comment.
Took a look at it, we are getting there. The whole PR needs a rebase. With #114 merging you should be able to run dep on your mac now
Maybe do one commit with all source code changes and another one cotaining the vendor/ + Gopkg.*. Makes it easier to review...
terraform/Dockerfile
Outdated
| RUN curl -sL https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_linux_amd64.zip > terraform_${TERRAFORM_VERSION}_linux_amd64.zip && \ | ||
| airworthy -v download https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_SHA256SUMS -S https://releases.hashicorp.com/terraform/${TERRAFORM_VERSION}/terraform_${TERRAFORM_VERSION}_SHA256SUMS.sig && \ | ||
| cat terraform_${TERRAFORM_VERSION}_SHA256SUMS | grep terraform_${TERRAFORM_VERSION}_linux_amd64.zip > terraform_${TERRAFORM_VERSION}_linux_amd64_SHA256SUMS && \ | ||
| sha256sum -c terraform_${TERRAFORM_VERSION}_linux_amd64_SHA256SUMS && \ |
There was a problem hiding this comment.
There is no need for this, airworthy is checking the sha256 sum already
terraform/Dockerfile
Outdated
| @@ -3,11 +3,17 @@ FROM alpine:3.6 | |||
|
|
|||
| RUN apk add --no-cache unzip curl | |||
|
|
|||
| # install airworthy | |||
| COPY airworthy /usr/local/bin/airworthy | |||
There was a problem hiding this comment.
Airworthy should be download from github releases page and sha256sum check performed on it
dippynark
force-pushed
the
66-fix-multi-cluster-envs
branch
from
38afa00
to
3d177dc
Compare
jetstack-ci-bot
removed
the
needs-rebase
dippynark
force-pushed
the
66-fix-multi-cluster-envs
branch
from
3d177dc
to
96b1992
Compare
simonswine
force-pushed
the
66-fix-multi-cluster-envs
branch
from
d3bf16f
to
e1acf79
Compare
simonswine
force-pushed
the
66-fix-multi-cluster-envs
branch
from
a7f4e23
to
94ae025
Compare
jetstack-bot
added
release-note
|
/approve |
jetstack-bot
added
the
approved
|
/lgtm |
|
@dippynark: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dippynark, simonswine The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue. |
What this PR does / why we need it: Multi cluster environements currently do not work with Tarmak. This PR fixes this by tagging subnets and instances appropriately so that clusters can function properly
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #66Special notes for your reviewer:
Release note: