Look for SSH config correctly in multi cluster environments #86
Conversation
|
@dippynark: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
pkg/tarmak/cluster/cluster.go
Outdated
| func (c *Cluster) HubName() string { | ||
| return fmt.Sprintf("%s-%s", c.environment.Name(), clusterv1alpha1.ClusterTypeHub) | ||
| } | ||
|
|
There was a problem hiding this comment.
This should ideally live in pkg/environment and then called through the environment interface
|
@dippynark I still need to merge this or is this already included in #100? |
|
@simonswine I have merged these changes into #100 so this no longer needs merging. This PR can be closed |
|
@dippynark thanks for the clarification |
What this PR does / why we need it: In multi-cluster environments, tarmak k8s clusters should look for vault cluster ssh credentials in the hub's folder rather than look in the cluster's folder
Special notes for your reviewer:
Release note: