feat(jest-cli): add forceExitAfterTestRun avg #1847
Closed
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
Oct 3, 2016
| const success = !result || result.success; | ||
| process.on('exit', () => process.exit(success ? 0 : 1)); | ||
|
|
||
| if (argv.forceExitAfterTestRun === true) process.exit(success ? 0 : 1); |
There was a problem hiding this comment.
our code style requires curly braces here.
cpojer
reviewed
Oct 3, 2016
| @@ -261,6 +261,12 @@ const options = { | |||
| 'Will run all tests affected by file changes in the last commit made.', | |||
| type: 'boolean', | |||
| }, | |||
| forceExitAfterTestRun: { | |||
There was a problem hiding this comment.
I'm not a fan of this name. Can we call it forceExit or exitOnComplete or something similar?
cpojer
reviewed
Oct 3, 2016
| forceExitAfterTestRun: { | ||
| default: false, | ||
| description: | ||
| 'After run all tests that force exit.', |
There was a problem hiding this comment.
'Force Jest to exit after all tests have completed running. This is useful when resources set up by test code cannot be adequately cleaned up.'
yutin1987
force-pushed
the
feature/forceExitAfterTestRun
branch
from
aabcb89
to
3f2710f
Compare
After run all tests that force exit when forceExit is true jestjs#1456
yutin1987
force-pushed
the
feature/forceExitAfterTestRun
branch
from
3f2710f
to
fff2730
Compare
cpojer
pushed a commit
that referenced
this pull request
Oct 17, 2016
okonet
pushed a commit
to okonet/jest
that referenced
this pull request
Nov 11, 2016
…estjs#1847) (jestjs#1870) * feat(jest-cli): add forceExit avg on cli After run all tests that force exit when forceExit is true jestjs#1456 * Fix typecheck & linter offences * Improve null check expression * Update index.js
nickpresta
pushed a commit
to nickpresta/jest
that referenced
this pull request
Nov 15, 2016
…estjs#1847) (jestjs#1870) * feat(jest-cli): add forceExit avg on cli After run all tests that force exit when forceExit is true jestjs#1456 * Fix typecheck & linter offences * Improve null check expression * Update index.js
trolster
added a commit
to trolster/urcli
that referenced
this pull request
Mar 2, 2017
The test run wouldn't exit because of the async call. This forces it to exit even if it can't correctly clean up after the tests. Referenced here: jestjs/jest#1847.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
…estjs#1847) (jestjs#1870) * feat(jest-cli): add forceExit avg on cli After run all tests that force exit when forceExit is true jestjs#1456 * Fix typecheck & linter offences * Improve null check expression * Update index.js
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After run all tests that force exit when forceExitAfterTestRun is true
#1456