Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) #1870

Merged
merged 4 commits into from Oct 17, 2016
Merged

RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) #1870

merged 4 commits into from Oct 17, 2016

Conversation

pastuxso
Copy link
Contributor

@pastuxso pastuxso commented Oct 5, 2016 •
edited

Solve issue #1456

Duplicated of PR #1847 but passing tests.

yutin1987 and others added 2 commits October 3, 2016 19:36
@yutin1987
feat(jest-cli): add forceExit avg on cli
fff2730 
After run all tests that force exit when forceExit is true

#1456
@pastuxso
Fix typecheck & linter offences
b4222fc
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Oct 5, 2016 •
edited

Current coverage is 87.76% (diff: 100%)

No coverage report found for master at fecbaca.

Powered by Codecov. Last update fecbaca...97d820d

@pastuxso pastuxso mentioned this pull request Oct 5, 2016
Closed
@pastuxso
Copy link
Contributor Author

pastuxso commented Oct 5, 2016 •
edited

I sent the PR #1870 improving the #1847 to pass travis-ci tests, @cpojer could you please check this out?

@pastuxso pastuxso changed the title feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) WIP: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) Oct 5, 2016
@pastuxso pastuxso changed the title WIP: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR #1847) Oct 5, 2016
@yutin1987
Copy link

Thank you for @pastuxso

@pastuxso
Copy link
Contributor Author

pastuxso commented Oct 6, 2016

@yutin1987 thanks to you!!

@jonathanong jonathanong mentioned this pull request Oct 9, 2016
Closed
@pastuxso
Copy link
Contributor Author

@cpojer ping

@cpojer
Copy link
Member

cpojer commented Oct 14, 2016

Hey, sorry, I've been busy with Yarn (see https://code.facebook.com/posts/1840075619545360 ). I'll look at this soon.

@cpojer cpojer merged commit 6fbeaa4 into jestjs:master Oct 17, 2016
@cpojer
Copy link
Member

cpojer commented Oct 17, 2016

merged! :)

@pastuxso pastuxso deleted the feature/forceExitAfterTestRun branch October 17, 2016 13:16
okonet pushed a commit to okonet/jest that referenced this pull request Nov 11, 2016
@pastuxso @okonet
RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR j…
4e5969c 
…estjs#1847) (jestjs#1870)

* feat(jest-cli): add forceExit avg on cli

After run all tests that force exit when forceExit is true

jestjs#1456

* Fix typecheck & linter offences

* Improve null check expression

* Update index.js
nickpresta pushed a commit to nickpresta/jest that referenced this pull request Nov 15, 2016
@pastuxso @nickpresta
RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR j…
54aadb4 
…estjs#1847) (jestjs#1870)

* feat(jest-cli): add forceExit avg on cli

After run all tests that force exit when forceExit is true

jestjs#1456

* Fix typecheck & linter offences

* Improve null check expression

* Update index.js
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@pastuxso @cpojer
RDY: feat(jest-cli): add forceExitAfterTestRun avg (Duplicated of PR j…
c1a2a33 
…estjs#1847) (jestjs#1870)

* feat(jest-cli): add forceExit avg on cli

After run all tests that force exit when forceExit is true

jestjs#1456

* Fix typecheck & linter offences

* Improve null check expression

* Update index.js
@agrawal-d agrawal-d mentioned this pull request Feb 16, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pastuxso @facebook-github-bot @codecov-io @yutin1987 @cpojer