fix: add setRequestInterception #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeaon
changed the title
jef
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Wow... Thank you very much. I appreciate you looking into this.
For our logs: https://pptr.dev/#?product=Puppeteer&version=v5.5.0&show=api-pagesetrequestinterceptionvalue
jef
changed the title
ven0ms99
pushed a commit
to ven0ms99/streetmerchant
that referenced
this pull request
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1311
Fixes #826
stops puppeteer exiting with exitcode 1
please head over to #1311 to see the detailed description
Testing
couldn't run streetmerchant 24/7 without
await page.setRequestInterception(true);New dependencies
no new dependencies