Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Interception is not enabled! and adblocker.js #1381

Closed
ratlaf opened this issue Dec 13, 2020 · 5 comments
Closed

Request Interception is not enabled! and adblocker.js #1381

ratlaf opened this issue Dec 13, 2020 · 5 comments

Comments

@ratlaf
Copy link

ratlaf commented Dec 13, 2020

This issue was opened, and then closed here after an attempted fix.

Unfortunately, I'm still seeing it off of a fresh pull today.

image

App will run for a random length of time (~30sec - 10min) before failing. I don't (currently) know puppeteer well enough to say why.

@ratlaf
Copy link
Author

ratlaf commented Dec 13, 2020

Adding this:

    if(!this._allowInterception) {
        console.log('>>>>INTERCEPTION FAILED!!!<<<<<');
        return
    }

To node_modules\puppeteer\lib\cjs\puppeteer\common\HTTPRequest.js:270 seems to work as an extremely quick and dirty fix.

@ratlaf
Copy link
Author

ratlaf commented Dec 13, 2020

@jef
Copy link
Owner

jef commented Dec 13, 2020

Just pushed this in. Feel free to pull down and test. Let me know if we need to make more updates.

Thanks!

@jef
Copy link
Owner

jef commented Dec 13, 2020

Also depending on when the last time you updated streetmerchant, this should've fixed it: #1312

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants