Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 3.0+ #600

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Support Django 3.0+ #600

merged 4 commits into from
Dec 5, 2019

Conversation

wm3ndez
Copy link
Member

@wm3ndez wm3ndez commented Dec 2, 2019

django.utils.six and some aliases were removed from Django in 3.0.

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage remained the same at ?% when pulling 561563c on wm3ndez:master into 22ccd97 on jazzband:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling d1ab97e on wm3ndez:master into 22ccd97 on jazzband:master.

@dmptrluke
Copy link

dmptrluke commented Dec 2, 2019

Since all of the functions in six only exist to provide Python 2 and 3 compatibility, it may be a better approach to check over the six documentation and replace the all usages of six functions with their native Python 3 versions.

For example, six.StringIO is just an alias for io.StringIO on Python 3, so we can use that directly. Another example is six.text_type, which is just an alias for the str type.

This was referenced Dec 3, 2019
@hugodes
Copy link

hugodes commented Dec 3, 2019

This would solve #601

@wm3ndez
Copy link
Member Author

wm3ndez commented Dec 3, 2019

@dmptrluke Yeah I think it makes sense to just remove PY2 support now. Will do that.

@dmptrluke
Copy link

We need to remove Programming Language :: Python :: 2.7 from setup.py, and probably add Django 3.0 to the readme, but it looks good!

@wm3ndez
Copy link
Member Author

wm3ndez commented Dec 3, 2019

@dmptrluke Done. Thanks!

@wm3ndez
Copy link
Member Author

wm3ndez commented Dec 3, 2019

@dmptrluke Should I merge the PR?

@dmptrluke
Copy link

I'm not sure what the best approach is - this is my first time contributing to this project, so I'm not sure who has permission to perform PyPi releases - we probably need to get them involved so we can properly publish these changes as a new version once merged.

@wm3ndez wm3ndez assigned timgraham and unassigned dmptrluke Dec 4, 2019
@timgraham timgraham removed their assignment Dec 4, 2019
@wm3ndez wm3ndez merged commit 4fe1854 into jazzband:master Dec 5, 2019
@camilonova
Copy link
Member

@wm3ndez Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants